From: Marek Marczykowski <marmarek@mimuw.edu.pl>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH RESENT] xl: Use macros for param parsing in network-attach, to prevent use explicit sizeof("param")
Date: Mon, 27 Jun 2011 16:37:14 +0200 [thread overview]
Message-ID: <4E08959A.20303@mimuw.edu.pl> (raw)
In-Reply-To: <19976.37678.636966.959895@mariner.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]
On 27.06.2011 16:26, Ian Jackson wrote:
> Marek Marczykowski writes ("[Xen-devel] [PATCH RESENT] xl: Use macros for param parsing in network-attach, to prevent use explicit sizeof("param")"):
>> xl: Use macros for param parsing in network-attach, to prevent use explicit sizeof("param")
>>
>> 'script=' length was wrong... Replaced calls to strncmp("param", *argv,
>> explicit sizeof("param")) with macro and helper function to extract parameter
>> value. Also introduce replace_string function to simplify code.
>
> I think I'm expecting an updated version of this ?
This is an updated version...
--
Pozdrawiam / Best Regards,
Marek Marczykowski | RLU #390519
marmarek at mimuw edu pl | xmpp:marmarek at staszic waw pl
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5842 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-06-27 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 18:54 [PATCH] libxl: off by one fix for new network-attach args parsing Marek Marczykowski
2011-06-17 17:58 ` Ian Jackson
2011-06-21 16:49 ` [PATCH RESENT] xl: Use macros for param parsing in network-attach, to prevent use explicit sizeof("param") Marek Marczykowski
2011-06-27 14:26 ` Ian Jackson
2011-06-27 14:37 ` Marek Marczykowski [this message]
2011-06-27 16:21 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E08959A.20303@mimuw.edu.pl \
--to=marmarek@mimuw.edu.pl \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).