From: Laszlo Ersek <lersek@redhat.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: Re: [xen-unstable test] 8803: regressions - FAIL
Date: Thu, 01 Sep 2011 20:55:01 +0200 [thread overview]
Message-ID: <4E5FD505.8020504@redhat.com> (raw)
In-Reply-To: <1314894926.28989.146.camel@zakaz.uk.xensource.com>
On 09/01/11 18:35, Ian Campbell wrote:
> diff -r bb97bd46df6c -r 4309ff953500 xen/include/asm-x86/config.h
> --- a/xen/include/asm-x86/config.h Thu Sep 01 16:03:21 2011 +0100
> +++ b/xen/include/asm-x86/config.h Thu Sep 01 17:34:41 2011 +0100
> @@ -49,6 +49,8 @@
>
> #ifdef MAX_PHYS_CPUS
> #define NR_CPUS MAX_PHYS_CPUS
> +#elif defined __i386__
> +#define NR_CPUS 128
> #else
> #define NR_CPUS 256
> #endif
Ah, sorry. This special-casing / after-the-fact #error for 32-bit is
actually there in the RHEL-5 fork, and there I bumped only the x86_64
default (the 32-bit one is set to 32). When I looked at the upstream
source, I noticed only a single case (set to 128), and I figured
upstream either makes the 32/64 distinction by different means, or they
support 128 PCPUs on 32-bit too, and 128 being >> than 32, I thought 256
should be fine as well.
I was wrong, sorry for wasting your time.
lacos
prev parent reply other threads:[~2011-09-01 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 15:59 [xen-unstable test] 8803: regressions - FAIL xen.org
2011-09-01 16:23 ` Ian Jackson
2011-09-01 16:35 ` Ian Campbell
2011-09-01 16:54 ` Ian Jackson
2011-09-01 18:55 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5FD505.8020504@redhat.com \
--to=lersek@redhat.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).