xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: AMD IOMMU intremap tables and IOAPICs
Date: Tue, 6 Sep 2011 17:03:30 +0100	[thread overview]
Message-ID: <4E664452.9020005@citrix.com> (raw)
In-Reply-To: <CAFLBxZYNB40rSb1Pxm9eJg5YWBkcYQU_HhYQ8gvrN+h2k1aL=A@mail.gmail.com>

On 06/09/11 16:57, George Dunlap wrote:
> On Tue, Sep 6, 2011 at 4:54 PM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> On 06/09/11 16:47, George Dunlap wrote:
>>> Wei,
>>>
>>> Quick question:  Am I reading the code correctly, that even with
>>> per-device interrupt remap tables, that GSIs are accounted to the
>>> intremap table of the corresponding IOAPIC, presumably because the
>>> IOMMU sees interrupts generated as GSIs as coming from the IOAPIC?  In
>>> that case, then we need all devices sharing the same IOAPIC must not
>>> have any vector collisions.  Is that correct?
>> Based on the ICH10 IO-APIC documentation with respect to auto EOIs, we
>> cant have any two IRQs across any IO-APICs sharing a vector,
>> irrespective of IOMMU or not.  (Because the EOI'ing an IO-APIC entry
>> only takes account of vector and not destination)
>>
>> If we were to disable the auto EOI broadcast and do manual EOI'ing (only
>> available on newer versions of the local apic) then we could reduce that
>> restriction to "no two IRQs in the same IO-APIC may share a vector".
> Hmm, so it sounds like enforcing non-sharing of vectors within a
> single IOAPIC is something we probably want to do even when we're not
> using an AMD IOMMU?
>
>  -George

Currently there is no code to disable auto EOI and do manual EOI
instead.  As a result, we should enforce non-sharing of vectors across
all IO-APICs.  It was on my irq cleanup list but seems to be a specific
problem for you at the moment.

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

  reply	other threads:[~2011-09-06 16:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06 15:47 AMD IOMMU intremap tables and IOAPICs George Dunlap
2011-09-06 15:54 ` Andrew Cooper
2011-09-06 15:57   ` George Dunlap
2011-09-06 16:03     ` Andrew Cooper [this message]
2011-09-06 16:00       ` George Dunlap
2011-09-06 16:06   ` Tim Deegan
2011-09-06 16:03     ` George Dunlap
2011-09-06 16:13     ` Keir Fraser
2011-09-06 16:25     ` Andrew Cooper
2011-09-07 11:18 ` Wei Wang2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E664452.9020005@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).