From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir.xen@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: 4.0/4.1 requests - IO-APIC EOI [RFC]
Date: Thu, 8 Sep 2011 14:56:57 +0100 [thread overview]
Message-ID: <4E68C9A9.8090707@citrix.com> (raw)
In-Reply-To: <4E68E1D30200007800055501@nat28.tlf.novell.com>
On 08/09/11 14:40, Jan Beulich wrote:
>>>> On 08.09.11 at 15:18, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> --- SNIP ---
>>
>> Attached is my first attempt at expanding the EOI to work on older
>> IO-APICs. It has not undergone any significant testing yet.
>>
>> Does this look suitable?
> It looks correct, but I'd prefer not having two io_apic_eoi_*() functions:
> Namely in the "normal" __eoi_IO_APIC_irq() case you have pin *and*
> vector readily available, and hence there is no need to look up anything.
> So perhaps a better option would be to pass both pin and vector to
> io_apic_eoi() (using e.g. -1 to identify the "unknown-needs-lookup"
> case).
>
> Jan
Ok - I will refactor with that suggestion.
Also, the code in end_level_ioapic_irq() suggests masking the entry
while playing with it, so I will include that as well.
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
next prev parent reply other threads:[~2011-09-08 13:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 9:19 4.0/4.1 requests Jan Beulich
2011-09-08 10:12 ` Jan Beulich
2011-09-08 11:29 ` Keir Fraser
2011-09-08 10:17 ` Keir Fraser
2011-09-08 10:48 ` Andrew Cooper
2011-09-08 11:11 ` Keir Fraser
2011-09-08 11:44 ` Jan Beulich
2011-09-08 13:18 ` 4.0/4.1 requests - IO-APIC EOI [RFC] Andrew Cooper
2011-09-08 13:40 ` Jan Beulich
2011-09-08 13:56 ` Andrew Cooper [this message]
2011-09-09 15:06 ` Re: 4.0/4.1 requests - IO-APIC EOI v2 [RFC] Andrew Cooper
2011-09-09 15:39 ` Jan Beulich
2011-09-09 15:55 ` Andrew Cooper
2011-09-09 16:03 ` Jan Beulich
2011-09-09 16:22 ` Re: 4.0/4.1 requests - IO-APIC EOI v3 [RFC] Andrew Cooper
2011-09-09 16:47 ` Re: 4.0/4.1 requests - IO-APIC EOI v4 [RFC] Andrew Cooper
2011-09-09 16:50 ` Andrew Cooper
2011-09-12 6:50 ` Jan Beulich
2011-09-12 10:15 ` Andrew Cooper
2011-09-12 10:23 ` Jan Beulich
2011-09-12 11:30 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E68C9A9.8090707@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).