Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking

[Avi Kivity <avi@redhat.com>]

On 09/08/2011 08:29 PM, Jeremy Fitzhardinge wrote:
> >  I don't think it's that expensive, especially compared to the
> >  double-context-switch and vmexit of the spinner going to sleep.  On
> >  AMD we do have to take an extra vmexit (on IRET) though.
>
> Fair enough - so if the vcpu blocks itself, it ends up being rescheduled
> in the NMI handler, which then returns to the lock slowpath.  And if its
> a normal hlt, then you can also take interrupts if they're enabled while
> spinning.

Yes.  To be clear, just execute 'hlt' and inherit the interrupt enable 
flag from the environment.

> And if you get nested NMIs (since you can get multiple spurious kicks,
> or from other NMI sources), then one NMI will get latched and any others
> will get dropped?

While we're in the NMI handler, any further NMIs will be collapsed and 
queued (so one NMI can be in service and just one other queued behind 
it).  We can detect this condition by checking %rip on stack.

>
> >  Well we could have a specialized sleep/wakeup hypercall pair like Xen,
> >  but I'd like to avoid it if at all possible.
>
> Yeah, that's something that just falls out of the existing event channel
> machinery, so it isn't something that I specifically added.  But it does
> mean that you simply end up with a hypercall returning on kick, with no
> real complexities.

It also has to return on interrupt, MNI, INIT etc.  "No real 
complexities" is a meaningless phrase on x86, though it is fertile 
ground for math puns.

-- 
error compiling committee.c: too many arguments to function