From: ANNIE LI <annie.li@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "jeremy@goop.org" <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: Re: [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture
Date: Fri, 18 Nov 2011 11:08:43 +0800 [thread overview]
Message-ID: <4EC5CC3B.4050808@oracle.com> (raw)
In-Reply-To: <20111117162955.GA6758@phenom.dumpdata.com>
On 2011-11-18 0:29, Konrad Rzeszutek Wilk wrote:
>>> The more normal way to do this would be to make gnttab_interface a
>>> pointer, define gnttab_v1_ops and do:
>>> gnttab_interface =&gnttab_v1_ops;
>>> or if the pointer overhead is significant remove that and just do a
>>> struct assignment:
>>> gnttab_interface = gnttab_v1_ops;
>>>
>> If using this way, we need two more public structures(gnttab_v1_ops
>> and gnttab_v2_ops), and two more functions to initialize those two
>> structures and then initialize the pointer gnttab_interface. It is
>> more complicated, am i missing something?
> Why two functions? I agree on the structures - but they need not to be
> public (they can be static).
>
> For a good example look at how apic_physflat is done.
Thanks, static structure is simpler and clean. I am very glad to change
that.:-)
Thanks
Annie
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-11-18 3:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 13:10 Improved patches of upstreaming grant table version 2 annie li
2011-11-16 13:23 ` [Xen-devel] " annie li
2011-11-16 13:48 ` [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture annie.li
2011-11-17 10:35 ` Ian Campbell
2011-11-17 16:06 ` annie li
2011-11-17 16:29 ` Konrad Rzeszutek Wilk
2011-11-18 3:08 ` ANNIE LI [this message]
2011-11-17 16:55 ` Ian Campbell
2011-11-18 10:07 ` [Xen-devel] " ANNIE LI
2011-11-18 10:54 ` Ian Campbell
2011-11-18 16:02 ` annie li
2011-11-18 16:04 ` [Xen-devel] " Ian Campbell
2011-11-21 9:51 ` ANNIE LI
2011-11-21 10:36 ` Ian Campbell
2011-11-16 13:49 ` [PATCH 2/3] xen/granttable: Grant tables V2 implementation annie.li
2011-11-18 10:13 ` ANNIE LI
2011-11-18 11:02 ` Ian Campbell
2011-11-18 13:52 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-11-18 14:00 ` Ian Campbell
2011-11-18 16:10 ` annie li
2011-11-18 18:05 ` Konrad Rzeszutek Wilk
2011-11-19 3:36 ` annie li
2011-11-21 9:51 ` ANNIE LI
2011-11-21 10:35 ` Ian Campbell
2011-11-21 11:42 ` annie li
2011-11-16 13:50 ` [PATCH 3/3] xen/granttable: Keep code format clean annie.li
2011-11-18 10:16 ` ANNIE LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC5CC3B.4050808@oracle.com \
--to=annie.li@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).