From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"agraf@suse.de" <agraf@suse.de>
Subject: Re: [PATCH 1/4] xen: introduce mc146818rtcxen
Date: Fri, 18 Nov 2011 07:58:10 -0600 [thread overview]
Message-ID: <4EC66472.7020706@codemonkey.ws> (raw)
In-Reply-To: <alpine.DEB.2.00.1111181145500.3519@kaball-desktop>
On 11/18/2011 05:46 AM, Stefano Stabellini wrote:
> On Tue, 15 Nov 2011, Stefano Stabellini wrote:
>> On Tue, 15 Nov 2011, Anthony Liguori wrote:
>>> On 11/15/2011 08:51 AM, stefano.stabellini@eu.citrix.com wrote:
>>>> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>>>
>>>> Xen doesn't need full RTC emulation in Qemu because the RTC is already
>>>> emulated by the hypervisor. In particular we want to avoid the timers
>>>> initialization so that Qemu doesn't need to wake up needlessly.
>>>>
>>>> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>>
>>> Yuck. There's got to be a better way to do this.
>>
>> Yeah, it is pretty ugly, I was hoping in some good suggestions to
>> improve this patch :)
>>
>>
>>> I think it would be better to name timers and then in Xen specific machine code,
>>> disable the RTC timers.
>>
>> Good idea!
>> I was thinking that I could implement an rtc_stop function in
>> mc146818rtc.c that stops and frees the timers.
You could also just stop the rtc_clock. The rtc is the only device that makes
use of the rtc_clock.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-11-18 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 14:48 [PATCH 0/4] prevent Qemu from waking up needlessly Stefano Stabellini
2011-11-15 14:51 ` [PATCH 1/4] xen: introduce mc146818rtcxen stefano.stabellini
2011-11-15 14:54 ` Anthony Liguori
2011-11-15 16:57 ` [Qemu-devel] " Stefano Stabellini
2011-11-18 11:46 ` Stefano Stabellini
2011-11-18 13:58 ` Anthony Liguori [this message]
2011-11-18 14:54 ` Anthony Liguori
2011-11-20 14:53 ` Avi Kivity
2011-11-21 20:49 ` Anthony Liguori
2011-11-21 11:05 ` Stefano Stabellini
2011-11-21 13:21 ` Paolo Bonzini
2011-11-15 14:51 ` [PATCH 2/4] xen: do not initialize the interval timer emulator stefano.stabellini
2011-11-15 14:51 ` [PATCH 3/4] xen: introduce an event channel for buffered io event notifications stefano.stabellini
2011-11-15 17:13 ` [Xen-devel] " Ian Campbell
2011-11-15 17:20 ` Stefano Stabellini
2011-11-15 17:24 ` Ian Campbell
2011-11-15 14:51 ` [PATCH 4/4] qemu_calculate_timeout: increase minimum timeout to 1h stefano.stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC66472.7020706@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).