From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 1/4] xen: introduce mc146818rtcxen Date: Fri, 18 Nov 2011 07:58:10 -0600 Message-ID: <4EC66472.7020706@codemonkey.ws> References: <1321368671-1134-1-git-send-email-stefano.stabellini@eu.citrix.com> <4EC27D0D.3040204@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" , "agraf@suse.de" List-Id: xen-devel@lists.xenproject.org On 11/18/2011 05:46 AM, Stefano Stabellini wrote: > On Tue, 15 Nov 2011, Stefano Stabellini wrote: >> On Tue, 15 Nov 2011, Anthony Liguori wrote: >>> On 11/15/2011 08:51 AM, stefano.stabellini@eu.citrix.com wrote: >>>> From: Stefano Stabellini >>>> >>>> Xen doesn't need full RTC emulation in Qemu because the RTC is already >>>> emulated by the hypervisor. In particular we want to avoid the timers >>>> initialization so that Qemu doesn't need to wake up needlessly. >>>> >>>> Signed-off-by: Stefano Stabellini >>> >>> Yuck. There's got to be a better way to do this. >> >> Yeah, it is pretty ugly, I was hoping in some good suggestions to >> improve this patch :) >> >> >>> I think it would be better to name timers and then in Xen specific machine code, >>> disable the RTC timers. >> >> Good idea! >> I was thinking that I could implement an rtc_stop function in >> mc146818rtc.c that stops and frees the timers. You could also just stop the rtc_clock. The rtc is the only device that makes use of the rtc_clock. Regards, Anthony Liguori