From mboxrd@z Thu Jan 1 00:00:00 1970 From: annie li Subject: Re: [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture Date: Sat, 19 Nov 2011 00:02:19 +0800 Message-ID: <4EC6818B.3010904@oracle.com> References: <4EC3B62F.6080702@oracle.com> <1321451304-13559-1-git-send-email-annie.li@oracle.com> <4EC62E77.7090007@oracle.com> <1321613689.3664.305.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3127504165445532786==" Return-path: In-Reply-To: <1321613689.3664.305.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "jeremy@goop.org" , "xen-devel@lists.xensource.com" , "konrad.wilk@oracle.com" , "kurt.hackel@oracle.com" , "linux-kernel@vger.kernel.org" , Paul Durrant List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============3127504165445532786== Content-Type: multipart/alternative; boundary="------------050509030203060808050700" This is a multi-part message in MIME format. --------------050509030203060808050700 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2011-11-18 18:54, Ian Campbell wrote: > Thanks for splitting these up. > > On Fri, 2011-11-18 at 10:07 +0000, ANNIE LI wrote: > >> [...] >> > > >> return value >> + * by bit operations. >> + */ >> + int (*query_foreign_access)(grant_ref_t); >> +}; >> + >> +static struct gnttab_ops gnttab_v1_ops; >> > > You don't actually need this forward declaration since the struct > definition and usage are ordered correctly. > > Yes, you are right, this line should be removed. >> +static struct gnttab_ops gnttab_v1_ops = { >> + .map_frames = gnttab_map_frames_v1, >> + .unmap_frames = gnttab_unmap_frames_v1, >> + .update_entry = update_grant_entry_v1, >> > > Any reason this one is not gnttab_foo? > Actually no, just keep the original name of this function. I'd like to change it, maybe gnttab_update_entry_v1 is better? Thanks Annie > Ian. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > --------------050509030203060808050700 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

On 2011-11-18 18:54, Ian Campbell wrote:

Thanks for splitting these up.

On Fri, 2011-11-18 at 10:07 +0000, ANNIE LI wrote:

[...]

return value
+        * by bit operations.
+        */
+       int (*query_foreign_access)(grant_ref_t);
+};
+
+static struct gnttab_ops gnttab_v1_ops;


You don't actually need this forward declaration since the struct
definition and usage are ordered correctly.

Yes, you are right, this line should be removed.

+static struct gnttab_ops gnttab_v1_ops = {
+       .map_frames                     = gnttab_map_frames_v1,
+       .unmap_frames                   = gnttab_unmap_frames_v1,
+       .update_entry                   = update_grant_entry_v1,


Any reason this one is not gnttab_foo?

Actually no, just keep the original name of this function. I'd like to change it, maybe gnttab_update_entry_v1 is better?

Thanks
Annie

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------050509030203060808050700-- --===============3127504165445532786== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============3127504165445532786==--