xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: William Cohen <wcohen@redhat.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: xen-devel@lists.xensource.com,
	oprofile-list <oprofile-list@lists.sourceforge.net>
Subject: Re: [Xen-devel] xenoprof patch for oprofile-0.9.7
Date: Tue, 20 Dec 2011 16:44:53 -0500	[thread overview]
Message-ID: <4EF101D5.20600@redhat.com> (raw)
In-Reply-To: <20111216210922.GA2295@andromeda.dapyr.net>

On 12/16/2011 04:09 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 29, 2011 at 04:28:06PM -0500, William Cohen wrote:
>> On 11/28/2011 05:45 PM, Konrad Rzeszutek Wilk wrote:
>>> On Mon, Nov 28, 2011 at 05:09:34PM -0500, William Cohen wrote:
>>>> I am rebasing Fedora rawhide oprofile package to oprofile-0.9.7. The xenoprof patches on http://xenoprof.sourceforge.net/#download look a bit dated. The newest version is for oprofile-0.9.5. 
>>>
>>> There was one posted some time ago.. Ah:
>>> http://www.flyn.org/patches/linux-xen-passive-oprofile/linux-3.0-xen-passive-oprofile.patch.gz
>>>
>>> I think that ones works , thought I haven't had a chance to test it
>>> myself.
>>>>
>>>> I massaged the patch oprofile-0.9.5-xen.patch to apply to oprofile-.0.9.7. Attached is that updated patch. Does this look reasonable? Is there a desire to get this into upstream oprofile? Or should the xenoprof patch be dropped?
>>>
>>> Well, the desire is to get a performance tool in upstream that works
>>> with Xen very very very much.
>>>
>>> The upstream is using the 'perf' framework which is different from oprofile
>>> and there hasn't been any patches to take advantage of it.
>>>
>>> So to answer your question:
>>>  1). Its awesome you have posted a patch. Will need to spend some time
>>>      with it and and with the version that was posted to see if there is
>>>      something missing. Sadly, the kernel patch is not very
>>>      upstream-compatible as is. But it will get to folks be able to
>>>      do some perf analysis instead of using benchmark tools.
>>
>> If anyone can exercise the patch and verify that it works well with the current upstream xen, that would be greatly appreciated.
> 
> So I tried to do it today but running in trouble of compiling it on
> Fedora Core 16. You wouldn't have any patches floating around to make it
> compile? (I used first a virgin 0.9.7 version).
> 
> Thanks!

Hi Konrad,

Sorry I didn't see this email earlier. 

The patch applies cleanly to oprofile 0.9.7 and builds on fc17. What was the error you got?  How are you configuring it? You should be able to do something like:

cd oprofile-0.9.7
patch -p1 -b < ~/oprofile-0.9.7-xen.patch
./autogen.sh
./configure --with-kernel-support --enable-gui=qt4 

Alternative you should be able to down load the src rpm from http://koji.fedoraproject.org/koji/buildinfo?buildID=276310

then

yum-builddep oprofile-0.9.7-1.src.rpm
rpm -Uvh oprofile-0.9.7-1.src.rpm
cd ~/rpmbuild/SPEC
rpmbuild -b oprofile.spec


Will

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

  reply	other threads:[~2011-12-20 21:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 22:09 xenoprof patch for oprofile-0.9.7 William Cohen
2011-11-28 22:45 ` Konrad Rzeszutek Wilk
2011-11-29 21:28   ` [Xen-devel] " William Cohen
2011-12-16 21:09     ` Konrad Rzeszutek Wilk
2011-12-20 21:44       ` William Cohen [this message]
2011-12-21 15:43         ` Konrad Rzeszutek Wilk
2011-12-22 13:52           ` William Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF101D5.20600@redhat.com \
    --to=wcohen@redhat.com \
    --cc=konrad@darnok.org \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).