From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Manschwetus Subject: Re: [PATCH 2/2] libxl: write vifname in xenstore if set. Date: Tue, 03 Jan 2012 17:20:17 +0100 Message-ID: <4F032AC1.5090800@gmx.de> References: <1325157276-4847-1-git-send-email-wei.liu2@citrix.com> <1325157276-4847-3-git-send-email-wei.liu2@citrix.com> <1325585762.25206.25.camel@zakaz.uk.xensource.com> <1325587168.24422.68.camel@liuw-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6217383698099509510==" Return-path: In-Reply-To: <1325587168.24422.68.camel@liuw-desktop> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Dies ist eine kryptografisch unterzeichnete Nachricht im MIME-Format. --===============6217383698099509510== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms080004060005030708020107" Dies ist eine kryptografisch unterzeichnete Nachricht im MIME-Format. --------------ms080004060005030708020107 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable This applies against 4.1.2, but untested, as I still have my Athlon X2 xen boot trouble. diff --git tools/libxl/libxl.c tools/libxl/libxl.c index 2b8f8f4..3c086d5 100644 --- tools/libxl/libxl.c +++ tools/libxl/libxl.c @@ -1229,6 +1229,12 @@ int libxl_device_nic_add(libxl_ctx *ctx, uint32_t domid, libxl_device_nic *nic) flexarray_append(back, libxl__sprintf(&gc, "%d", 1)); flexarray_append(back, "script"); flexarray_append(back, nic->script); + + if (nic->ifname) { + flexarray_append(back, "vifname"); + flexarray_append(back, nic->ifname); + } + flexarray_append(back, "mac"); flexarray_append(back, libxl__sprintf(&gc, "%02x:%02x:%02x:%02x:%02x:%02x", nic->mac[0], nic->mac[1], nic->mac[2], diff --git tools/libxl/xl_cmdimpl.c tools/libxl/xl_cmdimpl.c index 8270f34..8da8b88 100644 --- tools/libxl/xl_cmdimpl.c +++ tools/libxl/xl_cmdimpl.c @@ -393,6 +393,8 @@ for (i =3D 0; i < d_config->num_vifs; i++) { printf("\t(device\n"); printf("\t\t(vif\n"); + if (d_config->vifs[i].ifname) + printf("\t\t\t(vifname %s)\n", d_config->vifs[i].ifname); printf("\t\t\t(backend_domid %d)\n", d_config->vifs[i].backend_domid); printf("\t\t\t(frontend_domid %d)\n", domid); printf("\t\t\t(devid %d)\n", d_config->vifs[i].devid); Am 03.01.2012 11:39, schrieb Wei Liu: > On Tue, 2012-01-03 at 10:16 +0000, Ian Campbell wrote: >> On Thu, 2011-12-29 at 11:14 +0000, Wei Liu wrote: >>> Simple fix to enable user to specify vif names. >> >> Thanks. It is worth noting that the naming of the vif is implemented b= y >> the hotplug scripts and not by netback (which always uses vifX.Y). >> >=20 > Yes, I knew that after digging into hotplug scripts. :) >=20 > It seems that we need to backport these patches to earlier versions as > well. >=20 >=20 > Wei. >=20 >=20 > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >=20 --------------ms080004060005030708020107 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Kryptografische Unterschrift MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFSjCC BUYwggMuoAMCAQICAwhzEzANBgkqhkiG9w0BAQUFADB5MRAwDgYDVQQKEwdSb290IENBMR4w HAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmlu ZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZzAeFw0xMDA0 MDMxMjE2NDhaFw0xMjA0MDIxMjE2NDhaMEgxHDAaBgNVBAMTE0Zsb3JpYW4gTWFuc2Nod2V0 dXMxKDAmBgkqhkiG9w0BCQEWGUZsb3JpYW5NYW5zY2h3ZXR1c0BnbXguZGUwggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDOx228LSNcMIRtatTC835J0dYDQbcsng06PdtewI0r rwtxTSXndYotpjS257vzZOlIPMGRPUJL/FZgL7Nw8zaz2d/jCuQnzGgRukKefl2BZV4eW/xq hrc5tStj1h7+jZyhtGtR1Jt4Y8TOXF/bjBFCoZRgrfo316LoP/zW1WY34UbW3E2hLpkbRkP7 4Tj6tgpH1TZl1UtA2skuL3GQ3+Mx/Wsh7hCNGAvrV+3BGkA5bZMrKRd1Trcz1Bla68m1WAas xkNL/DbvgSWiIdyT7860wzcdKRS+ANlhtswsnwfj7arLNeBycQkiQeliFnQY2KBC9KZszkZ7 jdO1HgaEWKFLAgMBAAGjggEGMIIBAjAMBgNVHRMBAf8EAjAAMFYGCWCGSAGG+EIBDQRJFkdU byBnZXQgeW91ciBvd24gY2VydGlmaWNhdGUgZm9yIEZSRUUgaGVhZCBvdmVyIHRvIGh0dHA6 Ly93d3cuQ0FjZXJ0Lm9yZzBABgNVHSUEOTA3BggrBgEFBQcDBAYIKwYBBQUHAwIGCisGAQQB gjcKAwQGCisGAQQBgjcKAwMGCWCGSAGG+EIEATAyBggrBgEFBQcBAQQmMCQwIgYIKwYBBQUH MAGGFmh0dHA6Ly9vY3NwLmNhY2VydC5vcmcwJAYDVR0RBB0wG4EZRmxvcmlhbk1hbnNjaHdl dHVzQGdteC5kZTANBgkqhkiG9w0BAQUFAAOCAgEABTIxdlft8iVgfpvh+nR842ialjkFp5Fi ow5HOGkTG1tcPczEOvApu8267JHwy390X8ZsOvxZt9QSNmGwKAeQuX1meNgRzXBWuGT5YjOH 2qtwLvXr2AIPaRB1U8Qu2iKEKqjOY8x9SBrU5cFqrN7iySlo7kvvq8DQub5BFLd6FMsCaxZI Gyxd0FXVy57YEu/ZeknQutGS1NmGFc70hRe53DKILDh/bDO2r4yhvLOujJKjQf2kDkBoBZRI MyACJiqxz7R+/Dog9zbqcqEiB2YCe1x8KFmgwfevrBH3+MyAhlg5lKA3DTq41kiwlpgC+unC rgOfGoi1Y1IU/FoXgTil7G87L1IRrnVlcEcd6OiysFgwHsK6Y1ScVPoxJ3gmuqGsYDNlUxoH U8wLRVexlTuQjCLr3kwbTUlrWfXw1b30Fkx1RludNrP8MO6vDFW4/8tOF9CApplTBZ/FpMhs l2PF8suztvTobCuc7Z4DnqtfcqfPfcyNR610DaGOrp5eIjcn071z93qwzqOc0qxN1bcJZFM5 IAAKpvLLIlYzbK0fuHMb+xGFwCxjY6uQJrz77xpMu/bfS0LU5Xlzg+VfDFgpeUkY4tGS9e5v qRyUN2es5+TRqNR0hmdRj3zxL1ogBtcLLHdvcxmna8n5yyHwU2eZkXEr0JW0uOT903skt/mC /zUxggOUMIIDkAIBATCBgDB5MRAwDgYDVQQKEwdSb290IENBMR4wHAYDVQQLExVodHRwOi8v d3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmluZyBBdXRob3JpdHkxITAf BgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZwIDCHMTMAkGBSsOAwIaBQCgggHoMBgG CSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTEyMDEwMzE2MjAxN1ow IwYJKoZIhvcNAQkEMRYEFLFsiLsEsTtfiWGSdShp4O12+rw7MF8GCSqGSIb3DQEJDzFSMFAw CwYJYIZIAWUDBAECMAoGCCqGSIb3DQMHMA4GCCqGSIb3DQMCAgIAgDANBggqhkiG9w0DAgIB QDAHBgUrDgMCBzANBggqhkiG9w0DAgIBKDCBkQYJKwYBBAGCNxAEMYGDMIGAMHkxEDAOBgNV BAoTB1Jvb3QgQ0ExHjAcBgNVBAsTFWh0dHA6Ly93d3cuY2FjZXJ0Lm9yZzEiMCAGA1UEAxMZ Q0EgQ2VydCBTaWduaW5nIEF1dGhvcml0eTEhMB8GCSqGSIb3DQEJARYSc3VwcG9ydEBjYWNl cnQub3JnAgMIcxMwgZMGCyqGSIb3DQEJEAILMYGDoIGAMHkxEDAOBgNVBAoTB1Jvb3QgQ0Ex HjAcBgNVBAsTFWh0dHA6Ly93d3cuY2FjZXJ0Lm9yZzEiMCAGA1UEAxMZQ0EgQ2VydCBTaWdu aW5nIEF1dGhvcml0eTEhMB8GCSqGSIb3DQEJARYSc3VwcG9ydEBjYWNlcnQub3JnAgMIcxMw DQYJKoZIhvcNAQEBBQAEggEAk0OENOhfMVUYuu34CDC2DkgN82PnUSS//nATshHlxIiBjdsV xudVoWUUDhnq4FU10LFIf+zNdeq74GtJ905gqR6qtjKgEvBxM/UxrsnE1HDJEPWE8QIDEoLg dmNVeykDBXKR8H844kvk6G+2/A4IBPDhnH7Ip/KUSX1Gxm2a/+kFzGzeDXMBXYZ0EU9vN1k7 aOJ1lVaylSMK/PjGj4KRsb/c7rbinCOBYt6/2Vhz8b4emLzLAn1FEXn+vJ47Vf1gpV1cXAIF XDh0IIjZp3jwrxHSKe92K2EgmNXb8ejwjjQYH6p8Q8ve81H4sQHKbhYFOzYke1SDMR4b9VC4 Noz0dQAAAAAAAA== --------------ms080004060005030708020107-- --===============6217383698099509510== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============6217383698099509510==--