From: David Vrabel <david.vrabel@citrix.com>
To: Keir Fraser <keir@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] x86: emulate lea with two register operands correctly
Date: Thu, 5 Jan 2012 16:17:13 +0000 [thread overview]
Message-ID: <4F05CD09.4020503@citrix.com> (raw)
In-Reply-To: <CB2B7723.36EB2%keir@xen.org>
On 05/01/12 15:49, Keir Fraser wrote:
> On 05/01/2012 15:03, "David Vrabel" <david.vrabel@citrix.com> wrote:
>
>> An lea instruction with two register operands should raise an
>> undefined instruction exception.
>>
>> Skype does such a instruction and will crash when starting if it does
>> not get the exception.
>
> Thanks. I think it is a little nicer to check ea.type != OP_MEM, so I made
> that change before committing this patch. It's now in xen-unstable staging.
That works for me, thanks.
I also think this patch should be a 4.1 candidate.
David
prev parent reply other threads:[~2012-01-05 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 15:03 [PATCH] x86: emulate lea with two register operands correctly David Vrabel
2012-01-05 15:49 ` Keir Fraser
2012-01-05 16:06 ` Tim Deegan
2012-01-05 19:03 ` Keir Fraser
2012-01-05 16:17 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F05CD09.4020503@citrix.com \
--to=david.vrabel@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).