Re: [PATCH 4/5] xen/pciback: Expand the warning message to include domain id.

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 06/01/12 08:38, Jan Beulich wrote:
>>>> On 05.01.12 at 01:46, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>> When a PCI device is transferred to another domain and it is still
>> in usage (from the internal perspective), mention which other
>> domain is using it to aid in debugging.
>>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> ---
>>  drivers/xen/xen-pciback/xenbus.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
>> index 474d52e..fa130bd 100644
>> --- a/drivers/xen/xen-pciback/xenbus.c
>> +++ b/drivers/xen/xen-pciback/xenbus.c
>> @@ -243,8 +243,10 @@ static int xen_pcibk_export_device(struct 
>> xen_pcibk_device *pdev,
>>  	dev_dbg(&dev->dev, "registering for %d\n", pdev->xdev->otherend_id);
>>  	if (xen_register_device_domain_owner(dev,
>>  					     pdev->xdev->otherend_id) != 0) {
>> -		dev_err(&dev->dev, "device has been assigned to another " \
>> -			"domain! Over-writting the ownership, but beware.\n");
>> +		int other_domain = xen_find_device_domain_owner(dev);
>> +		dev_err(&dev->dev, "device has been assigned to %d " \
>> +			"domain! Over-writting the ownership, but beware.\n",
>> +			other_domain);
> As you're touching this anyway, how about fixing the other minor
> issues with it too? E.g.
>
> 		dev_err(&dev->dev, "Device appears to be assigned to dom%d!"
> 			" Overwriting the ownership, but beware.\n",
> 			xen_find_device_domain_owner(dev));
>
> (a native English speaker may want to comment the "but beware"
> part - it reads odd for me).
>
> Jan

Agreed - the "but beware" is superfluous to the meaning of the error
message.

~Andrew

>>  		xen_unregister_device_domain_owner(dev);
>>  		xen_register_device_domain_owner(dev, pdev->xdev->otherend_id);
>>  	}
>> -- 
>> 1.7.7.4
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com 
>> http://lists.xensource.com/xen-devel 
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com