From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] xen/sched_credit: Use delay to control scheduling frequency Date: Fri, 6 Jan 2012 14:50:06 -0500 Message-ID: <4F07506E.5050500@eu.citrix.com> References: <18f40e1d027491964a88.1324889181@wsm-ep-n0> <4F0176940200007800069FE8@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F0176940200007800069FE8@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" , "raistlin@linux.it" , Ian Campbell , Hui Lv List-Id: xen-devel@lists.xenproject.org On 02/01/12 03:19, Jan Beulich wrote: >>>> On 26.12.11 at 09:46, Hui Lv wrote: >> Some modifications for this patch. >> 1.Based on George's proposal, added a ratelimit_us element to csched_priv to >> constrain prv->ratelimit_us<= 1000* prv->tslice_ms in csched_init. > I do not see why you need a per-scheduler-instance variable for > issuing the warning and correcting the value - one warning (during > the first initialization) is entirely sufficient. (Otoh the already existing > tslice_ms field is pointless currently too, as it never gets changed > after being initialized from sched_credit_tslice_ms - George?) Before the 4.2 release, I plan to add SYSCTL_scheduler_op calls for the credit scheduler for both the timeslice and ratelimiting. But I don't think it's necessary for this patch to be admitted. -George