From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [PATCH 4/4] xen kconfig: describe xen tmem in the config menu Date: Tue, 24 Jan 2012 09:30:15 +0100 Message-ID: <4F1E6C17.7060609@redhat.com> References: <1325842991-4404-1-git-send-email-drjones@redhat.com> <1325842991-4404-5-git-send-email-drjones@redhat.com> <20120123183454.GA12542@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120123183454.GA12542@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: Andrew Jones , xen-devel@lists.xensource.com, jeremy@goop.org, virtualization@lists.linux-foundation.org List-Id: xen-devel@lists.xenproject.org On 01/23/2012 07:34 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 06, 2012 at 10:43:11AM +0100, Andrew Jones wrote: >> Add a description to the config menu for xen tmem. > > I am not sure what this patch gets us. If this is to minimize the > size of the module - so say it gets loaded, but tmem-enabled is > not set nor cleancache and we just have it consuming memory - we can do it > via returning -ENODEV on the module load. But why compile in something that one may never use? At least with this patch I'll have a choice to turn it off if I don't need it. For example when I build hardened kernel, I'd like to turn of all unnecessary features for a particular config (i.e. reduce attack surface as much as possible). -- Thanks, Igor