xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: console: introduce console=none option
Date: Thu, 26 Jan 2012 12:19:58 +0000	[thread overview]
Message-ID: <4F2144EE.9040808@citrix.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

XenServer by default boots without a serial console (buggy hardware
reasons) and dom0 displays a splash screen.  Unfortunately, having Xen
writing to the vga text area looks ugly whilst dom0 is trying to set up
non-text mode and display  the splash screen.

We have been using "console=" to prevent this behavior for a while, but
presented herewith is a patch to fix the problem correctly.

~Andrew


[-- Attachment #2: console-param-none.patch --]
[-- Type: text/x-patch, Size: 1098 bytes --]

Console: introduce console=none command line parameter

Currenty, not specifying 'console=<foo>' on the command line causes
Xen to default to 'vga'.  Alternativly, the user can explicitly
specifiy 'console=vga|com1|com2'.

However, there is no way to specify that neither vga nor serial should
be used.  Specifying 'console=' does have the effect that neither vga
nor serial is set up, but at the cost of an "Bad console= option ''"
warning.

Therefore, expliticly support a 'console=none' option which does not
set up vga and does not set up serial, but does not trigger the bad
console warning.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff -r a2a8089b1ffb xen/drivers/char/console.c
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -549,6 +549,8 @@ void __init console_init_preirq(void)
             p++;
         if ( !strncmp(p, "vga", 3) )
             vga_init();
+        else if ( !strncmp(p, "none", 4) )
+            continue;
         else if ( strncmp(p, "com", 3) ||
                   (sercon_handle = serial_parse_handle(p)) == -1 )
         {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2012-01-26 12:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26 12:19 Andrew Cooper [this message]
2012-01-26 14:41 ` console: introduce console=none option Jan Beulich
2012-01-26 14:58   ` Andrew Cooper
2012-01-26 16:00     ` Jan Beulich
2012-01-26 16:08       ` Tim Deegan
2012-01-26 16:09       ` Ian Campbell
2012-01-26 16:33       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2144EE.9040808@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).