From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 2/5] xen: disable rtc_clock Date: Mon, 30 Jan 2012 12:59:46 +0100 Message-ID: <4F268632.8040801@redhat.com> References: <1327667215-5411-2-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" List-Id: xen-devel@lists.xenproject.org On 01/30/2012 12:56 PM, Stefano Stabellini wrote: >> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. > > Good point. > I should check for rtc_clock == host_clock. > >> > Why do you need to instantiate an RTC at all? > I don't, in fact in previous versions of this patch series I tried to do > that but it is difficult and makes the common code worse, so I followed > Anthony's suggestion of just disabling the rtc_clock. I see. It shouldn't surprise you that I completely disagree with Anthony on this. :) Paolo