From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH v2 2/5] xen: disable rtc_clock Date: Mon, 30 Jan 2012 13:28:07 -0600 Message-ID: <4F26EF47.9090108@codemonkey.ws> References: <1327667215-5411-2-git-send-email-stefano.stabellini@eu.citrix.com> <4F268632.8040801@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F268632.8040801@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Paolo Bonzini Cc: "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 01/30/2012 05:59 AM, Paolo Bonzini wrote: > On 01/30/2012 12:56 PM, Stefano Stabellini wrote: >>> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. >> >> Good point. >> I should check for rtc_clock == host_clock. >> >>> > Why do you need to instantiate an RTC at all? >> I don't, in fact in previous versions of this patch series I tried to do >> that but it is difficult and makes the common code worse, so I followed >> Anthony's suggestion of just disabling the rtc_clock. > > I see. It shouldn't surprise you that I completely disagree with Anthony on > this. :) Give me some credit at least... The original patches didn't disable the RTC, it introduced a half-neutered Xen specific RTC. My original suggestion (which I still think is the best approach) is to change the RTC emulation to not use a second timer at all. Regards, Anthony Liguori > Paolo >