From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Wang <wei.wang2@amd.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir.xen@gmail.com>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [xen-unstable test] 11807: regressions - FAIL
Date: Thu, 2 Feb 2012 15:49:38 +0000 [thread overview]
Message-ID: <4F2AB092.7020003@citrix.com> (raw)
In-Reply-To: <20266.33471.444202.819846@mariner.uk.xensource.com>
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
This patch ought to help narrow down the problem.
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
[-- Attachment #2: irq-migration-debug.patch --]
[-- Type: text/x-patch, Size: 1449 bytes --]
# HG changeset patch
# Parent e2722b24dc0962de37215320b05d1bb7c4c42864
IRQ: Add extra debugging to help track down why this assertion is failing
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff -r e2722b24dc09 xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -608,6 +608,8 @@ void move_native_irq(struct irq_desc *de
desc->handler->enable(desc);
}
+static void dump_irqs(unsigned char key);
+
fastcall void smp_irq_move_cleanup_interrupt(struct cpu_user_regs *regs)
{
unsigned vector, me;
@@ -667,7 +669,18 @@ fastcall void smp_irq_move_cleanup_inter
if ( desc->arch.used_vectors )
{
- ASSERT(test_bit(vector, desc->arch.used_vectors));
+ if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
+ {
+ bitmap_scnlistprintf(keyhandler_scratch,
+ sizeof(keyhandler_scratch),
+ desc->arch.used_vectors->_bits,
+ NR_VECTORS);
+ printk("*** IRQ BUG found ***\n"
+ "CPU%d -Testing vector %d from bitmap %s\n",
+ me, vector, keyhandler_scratch);
+ dump_irqs('i');
+ BUG();
+ }
clear_bit(vector, desc->arch.used_vectors);
}
}
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2012-02-02 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 7:04 [xen-unstable test] 11807: regressions - FAIL xen.org
2012-02-02 12:34 ` Ian Jackson
2012-02-02 15:49 ` Andrew Cooper [this message]
2012-02-07 18:09 ` Ian Jackson
2012-02-07 10:23 ` Keir Fraser
2012-02-07 18:44 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2AB092.7020003@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir.xen@gmail.com \
--cc=wei.wang2@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).