From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Keir (Xen.org)" <keir@xen.org>
Subject: Re: [PATCH 4 of 4] CONFIG: remove #ifdef __ia64__ from the x86 arch tree
Date: Thu, 9 Feb 2012 11:52:23 +0000 [thread overview]
Message-ID: <4F33B377.4080605@citrix.com> (raw)
In-Reply-To: <4F33B5FA0200007800071DBB@nat28.tlf.novell.com>
On 09/02/12 11:03, Jan Beulich wrote:
>>>> On 08.02.12 at 18:24, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> @@ -227,12 +223,6 @@ static int vioapic_write(
>> vioapic_write_indirect(vioapic, length, val);
>> break;
>>
>> -#if VIOAPIC_IS_IOSAPIC
>> - case VIOAPIC_REG_EOI:
>> - vioapic_update_EOI(v->domain, val);
>> - break;
>> -#endif
>> -
> Would you mind keeping that code, putting the call inside a conditional
> checking VIOAPIC_VERSION_ID >= 0x20?
>
> Jan
Yes - In actual fact, I considered the same just after I emailed this patch.
I shall respin.
~Andrew
>> default:
>> break;
>> }
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
next prev parent reply other threads:[~2012-02-09 11:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:45 [PATCH 0 of 4] Prune outdated/impossible preprocessor symbols, and update VIOAPIC emulation Andrew Cooper
2012-02-08 16:45 ` [PATCH 1 of 4] CONFIG: remove CONFIG_SMP #ifdefs Andrew Cooper
2012-02-08 17:22 ` Andrew Cooper
2012-02-09 10:54 ` Jan Beulich
2012-02-09 11:51 ` Andrew Cooper
2012-02-09 14:56 ` Jan Beulich
2012-02-08 16:45 ` [PATCH 2 of 4] CONFIG: remove smp barrier definitions Andrew Cooper
2012-02-09 10:49 ` Jan Beulich
2012-02-09 12:42 ` Keir Fraser
2012-02-08 16:45 ` [PATCH 3 of 4] VIOAPIC: Emulate a version 0x20 IOAPIC Andrew Cooper
2012-02-08 17:05 ` Tim Deegan
2012-02-08 9:12 ` Keir Fraser
2012-02-08 17:13 ` Andrew Cooper
2012-02-08 16:45 ` [PATCH 4 of 4] CONFIG: remove #ifdef __ia64__ from the x86 arch tree Andrew Cooper
2012-02-08 17:24 ` Andrew Cooper
2012-02-09 11:03 ` Jan Beulich
2012-02-09 11:52 ` Andrew Cooper [this message]
2012-02-09 13:08 ` Andrew Cooper
2012-02-09 14:58 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33B377.4080605@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).