From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 4 of 4] CONFIG: remove #ifdef __ia64__ from
 the x86 arch tree
Date: Thu, 9 Feb 2012 11:52:23 +0000
Message-ID: <4F33B377.4080605@citrix.com>
References: <patchbomb.1328719535@andrewcoop.uk.xensource.com>
	<d59767433c7f8913c198.1328719539@andrewcoop.uk.xensource.com>
	<4F32AFBF.7090201@citrix.com>
	<4F33B5FA0200007800071DBB@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4F33B5FA0200007800071DBB@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Keir
	(Xen.org)" <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 09/02/12 11:03, Jan Beulich wrote:
>>>> On 08.02.12 at 18:24, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> @@ -227,12 +223,6 @@ static int vioapic_write(
>>         vioapic_write_indirect(vioapic, length, val);
>>         break;
>>
>> -#if VIOAPIC_IS_IOSAPIC
>> -    case VIOAPIC_REG_EOI:
>> -        vioapic_update_EOI(v->domain, val);
>> -        break;
>> -#endif
>> -
> Would you mind keeping that code, putting the call inside a conditional
> checking VIOAPIC_VERSION_ID >= 0x20?
>
> Jan

Yes - In actual fact, I considered the same just after I emailed this patch.

I shall respin.

~Andrew

>>     default:
>>         break;
>>     }

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com