From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH v3 1/6] suspend: add infrastructure Date: Thu, 09 Feb 2012 14:29:32 +0100 Message-ID: <4F33CA3C.50903@redhat.com> References: <1328698819-31269-1-git-send-email-kraxel@redhat.com> <1328698819-31269-2-git-send-email-kraxel@redhat.com> <20120209084816.GB18866@redhat.com> <4F33A3C1.1080108@redhat.com> <20120209111928.GH18866@redhat.com> <4F33B5E7.7070502@redhat.com> <20120209123725.GK18866@redhat.com> <4F33C00F.7040408@redhat.com> <20120209131714.GM18866@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120209131714.GM18866@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Gleb Natapov Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org Hi, >>> We need to give ACPI ability to prevent wakeup. So, for instance, if RTC >>> alarm calls wakeup but ACPI detects that RTC_EN is cleared it can >>> prevent it. >> >> Yea, already figured that after reading your rtc reply ... >> >> One more incremental attached for review. >> > We can start from that. But other devices can use STS/EN registers > from different GPEs, so they will have same "reason" bit, but in > different registers. Yes, we'll need more reason bits then, basically one per device. > Also I'd rather hide this logic in ACPI code > instead of having it in vl.c. The acpi bits will be in acpi of course. I'll try to get a complete v4 out of the door later today, that should the direction I'm heading to more clear than these incremental bits. cheers, Gerd