From mboxrd@z Thu Jan 1 00:00:00 1970 From: ANNIE LI Subject: [PATCH] hvm: Correct RTC time offset update error due to tm->tm_year Date: Mon, 20 Feb 2012 15:19:59 +0800 Message-ID: <4F41F41F.9060601@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010309020207000005030804" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" Cc: Kurt Hackel , Dan Magenheimer , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------010309020207000005030804 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi In rtc_set_time, mktime is called to calculate seconds since 1970/01/01, input parameters of mktime are required to be in normal date format. Such as: year=1980, mon=12, day=31, hour=23, min=59, sec=59. However, the current input parameter of mktime is tm->tm_year, and it is the number of years since 1900. (For example, if current time is 2012/12/31, and tm->tm_year is 112). This is not suitable for requirement of mktime. So I think tm->tm_year should be changed to tm->tm_year+1900 when calling mktime. Please check the patch attached. Thanks, Annie --------------010309020207000005030804 Content-Type: text/plain; name="rtc-timeoffset.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="rtc-timeoffset.patch" IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBQYXJlbnQgZjI1NDNmNDQ5YTQ5Yjg5NzliZWNiZjY4 ODhlMDA5OTczNDI3MDg5YQpodm06IGNvcnJlY3QgUlRDIHRpbWUgb2Zmc2V0IHVwZGF0ZSBl cnJvciBkdWUgdG8gdG0tPnRtX3llYXIKCm1rdGltZSByZXF1aXJlcyBpbnB1dCB5ZWFyIGlu IG5vcm1hbCBkYXRlIGZvcm1hdCwgaS5lLiAxOTgwLiBTbyBpdCBpcyBuZWNlc3NhcnkKdG8g Y2hhbmdlIHRtLT50bV95ZWFyIHRvIHRtLT50bV95ZWFyKzE5MDAuIE90aGVyd2lzZSwgdGhl IGNhbGN1bGF0aW9uIHJlc3VsdApvZiBta3RpbWUgaXMgaW5jb3JyZWN0LgoKU2lnbmVkLW9m Zi1ieTogQW5uaWUgTGkgPGFubmllLmxpQG9yYWNsZS5jb20+CgpkaWZmIC1yIGYyNTQzZjQ0 OWE0OSB4ZW4vYXJjaC94ODYvaHZtL3J0Yy5jCi0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vcnRj LmMJTW9uIEZlYiAxMyAxNzo1Nzo0NyAyMDEyICswMDAwCisrKyBiL3hlbi9hcmNoL3g4Ni9o dm0vcnRjLmMJTW9uIEZlYiAyMCAxNDozOTowMCAyMDEyICswODAwCkBAIC0xNjUsNyArMTY1 LDcgQEAgc3RhdGljIHZvaWQgcnRjX3NldF90aW1lKFJUQ1N0YXRlICpzKQogICAgICAgCiAg ICAgQVNTRVJUKHNwaW5faXNfbG9ja2VkKCZzLT5sb2NrKSk7CiAKLSAgICBiZWZvcmUgPSBt a3RpbWUodG0tPnRtX3llYXIsIHRtLT50bV9tb24gKyAxLCB0bS0+dG1fbWRheSwKKyAgICBi ZWZvcmUgPSBta3RpbWUodG0tPnRtX3llYXIgKyAxOTAwLCB0bS0+dG1fbW9uICsgMSwgdG0t PnRtX21kYXksCiAJCSAgICB0bS0+dG1faG91ciwgdG0tPnRtX21pbiwgdG0tPnRtX3NlYyk7 CiAgICAgCiAgICAgdG0tPnRtX3NlYyA9IGZyb21fYmNkKHMsIHMtPmh3LmNtb3NfZGF0YVtS VENfU0VDT05EU10pOwpAQCAtMTc5LDcgKzE3OSw3IEBAIHN0YXRpYyB2b2lkIHJ0Y19zZXRf dGltZShSVENTdGF0ZSAqcykKICAgICB0bS0+dG1fbW9uID0gZnJvbV9iY2Qocywgcy0+aHcu Y21vc19kYXRhW1JUQ19NT05USF0pIC0gMTsKICAgICB0bS0+dG1feWVhciA9IGZyb21fYmNk KHMsIHMtPmh3LmNtb3NfZGF0YVtSVENfWUVBUl0pICsgMTAwOwogCi0gICAgYWZ0ZXIgPSBt a3RpbWUodG0tPnRtX3llYXIsIHRtLT50bV9tb24gKyAxLCB0bS0+dG1fbWRheSwKKyAgICBh ZnRlciA9IG1rdGltZSh0bS0+dG1feWVhciArIDE5MDAsIHRtLT50bV9tb24gKyAxLCB0bS0+ dG1fbWRheSwKICAgICAgICAgICAgICAgICAgICB0bS0+dG1faG91ciwgdG0tPnRtX21pbiwg dG0tPnRtX3NlYyk7CiAKICAgICAvKiBXZSB1c2UgdGhlIGd1ZXN0J3Mgc2V0dGluZyBvZiB0 aGUgUlRDIHRvIGRlZmluZSB0aGUgbG9jYWwtdGltZSAK --------------010309020207000005030804 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------010309020207000005030804--