xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <dvrabel@cantab.net>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Dave Scott <Dave.Scott@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 05 of 23] libxl: drop 8M slack for PV guests
Date: Tue, 21 Feb 2012 10:53:01 +0000	[thread overview]
Message-ID: <4F43778D.2080507@cantab.net> (raw)
In-Reply-To: <1329819046.25232.69.camel@dagon.hellion.org.uk>

On 21/02/12 10:10, Ian Campbell wrote:
> On Tue, 2012-02-21 at 10:10 +0000, Stefano Stabellini wrote:
>> On Mon, 20 Feb 2012, Ian Jackson wrote:
>>> Ian Campbell writes ("[Xen-devel] [PATCH 05 of 23] libxl: drop 8M slack for PV guests"):
>>>> libxl: drop 8M slack for PV guests.
>>>>
>>>> As far as I can tell this serves no purpose. I think it relates to the old
>>>> 8M to "account for backend allocations" which we used to add. This leaves a bit
>>>> of unpopulated space in the Pseudo-physical address space which can be used by
>>>> backends when mapping foreign memory. However 8M is not representative of that
>>>> any more and modern kernels do not operate in this way anyway.
>>>>
>>>> I suspect an argument could be made for removing this from the libxl API
>>>> altogether but instead lets just set the overhead to 0.
>>>
>>> I think this is plausible but I'd like to hear from Stefano, who iirc
>>> may have some knowledge about the reason for this 8Mb.
>>
>> It comes from XenD (and XAPI too, if I recall correctly), see this
>> comment in tools/python/xen/xend/image.py:
> 
> That doesn't answer the "why" though.
> 
> I think I should just be more assertive since I believe I do actually
> know why the 8 is there (or certainly nobody appears to know any
> better). I'll update the changelog to read:
> 
>         This serves no purpose. It relates to the old 8M to "account for
>         backend allocations" which we used to add. This leaves a bit of
>         unpopulated space in the Pseudo-physical address space which can
>         be used by backends when mapping foreign memory. However 8M is
>         not representative of that any more and modern kernels do not
>         operate in this way anyway.

Should a similar fix be applied to Xen as well for dom0?

Daid

  reply	other threads:[~2012-02-21 10:53 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 16:52 [PATCH 00 of 23] libxl: improved handling for default values in API Ian Campbell
2012-02-13 16:52 ` [PATCH 01 of 23] libxl: Document _init/_dispose/_setdefault functions Ian Campbell
2012-02-20 19:08   ` Ian Jackson
2012-02-21 10:18     ` Ian Campbell
2012-02-13 16:52 ` [PATCH 02 of 23] libxl: provide _init and _setdefault for libxl_domain_create_info Ian Campbell
2012-02-20 19:09   ` Ian Jackson
2012-02-13 16:52 ` [PATCH 03 of 23] libxl: provide _init and _setdefault for libxl_domain_build_info Ian Campbell
2012-02-13 16:52 ` [PATCH 04 of 23] libxl: use an explicit LIBXL_TIMER_MODE_DEFAULT value Ian Campbell
2012-02-20 19:16   ` Ian Jackson
2012-02-13 16:52 ` [PATCH 05 of 23] libxl: drop 8M slack for PV guests Ian Campbell
2012-02-20 19:15   ` Ian Jackson
2012-02-21 10:10     ` Stefano Stabellini
2012-02-21 10:10       ` Ian Campbell
2012-02-21 10:53         ` David Vrabel [this message]
2012-02-21 10:59           ` Ian Campbell
2012-02-21 15:27         ` Dan Magenheimer
2012-02-13 16:52 ` [PATCH 06 of 23] libxl: allow specification of testidl random seed Ian Campbell
2012-02-20 19:18   ` Ian Jackson
2012-02-13 16:52 ` [PATCH 07 of 23] libxl: introduce a descriminating default value for memkb fields Ian Campbell
2012-02-20 19:24   ` Ian Jackson
2012-02-13 16:52 ` [PATCH 08 of 23] libxl: disk: use _init/_setdefault Ian Campbell
2012-02-13 16:52 ` [PATCH 09 of 23] libxl: nic: " Ian Campbell
2012-02-13 16:52 ` [PATCH 10 of 23] libxl: vfb/vkb: " Ian Campbell
2012-02-13 16:52 ` [PATCH 11 of 23] libxl: make libxl_device_console internal Ian Campbell
2012-02-20 19:20   ` Ian Jackson
2012-02-21 10:23     ` Ian Campbell
2012-02-21 12:31       ` Ian Jackson
2012-02-13 16:52 ` [PATCH 12 of 23] libxl: pci: use _init/_setdefault Ian Campbell
2012-02-13 16:52 ` [PATCH 13 of 23] libxl: add new "defbool" built in type Ian Campbell
2012-02-20 19:14   ` Ian Jackson
2012-02-21 10:24     ` Ian Campbell
2012-02-13 16:53 ` [PATCH 14 of 23] libxl: make boolean members of libxl_domain_create_info into libxl_defbool Ian Campbell
2012-02-20 19:18   ` Ian Jackson
2012-02-13 16:53 ` [PATCH 15 " Ian Campbell
2012-02-20 19:25   ` Ian Jackson
2012-02-21 10:58     ` Ian Campbell
2012-02-13 16:53 ` [PATCH 16 of 23] libxl: switch generation id control to libxl_defbool Ian Campbell
2012-02-20 19:16   ` Ian Jackson
2012-02-21 11:01   ` Ian Campbell
2012-02-13 16:53 ` [PATCH 17 of 23] libxl: use defbool for graphics related options Ian Campbell
2012-02-20 19:22   ` Ian Jackson
2012-02-13 16:53 ` [PATCH 18 of 23] libxl: do not explicitly initialise members of build info to zero Ian Campbell
2012-02-20 19:20   ` Ian Jackson
2012-02-13 16:53 ` [PATCH 19 of 23] libxl: switch device model selection over to libxl_defbool Ian Campbell
2012-02-13 16:53 ` [PATCH 20 of 23] libxl: add libxl_domain_build_info_init_type Ian Campbell
2012-02-20 19:22   ` Ian Jackson
2012-02-20 19:24   ` Ian Jackson
2012-02-13 16:53 ` [PATCH 21 of 23] libxl: Make IDL KeyedUnion keyvar an idl.Field Ian Campbell
2012-02-20 19:17   ` Ian Jackson
2012-02-13 16:53 ` [PATCH 22 of 23] libxl: idl: generate KeyedUnion key member as part of the KeyedUnion Ian Campbell
2012-02-13 17:08   ` Ian Jackson
2012-02-13 17:13     ` Ian Campbell
2012-02-13 16:53 ` [PATCH 23 of 23] libxl: autogenerate libxl_FOO_init and libxl_FOO_init_FIELD Ian Campbell
2012-02-20 19:24   ` Ian Jackson
2012-02-21 10:11     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F43778D.2080507@cantab.net \
    --to=dvrabel@cantab.net \
    --cc=Dave.Scott@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).