From: Jim Fehlig <jfehlig@suse.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Bamvor Jian Zhang <bjzhang@suse.com>
Subject: Re: [xen-devel] [PATCH] libxl: fix compile error of libvirt
Date: Wed, 22 Feb 2012 14:40:12 -0700 [thread overview]
Message-ID: <4F4560BC.30002@suse.com> (raw)
In-Reply-To: <20292.55062.209546.961330@mariner.uk.xensource.com>
Ian Jackson wrote:
> Bamvor Jian Zhang writes ("Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt"):
>
>> Ian Jackson wrote:
>>
>>> Users of libxl should not be using libxc directly and therefore should
>>> not be including xenctrl.h.
>>>
> ...
>
>> but after your commit "23174:751c6dcec0d4"(remove xenctrl.h from libxl.h), the aplication(like libvirt) compile fail. How do i deal with it?
>> it seems that add __XEN_TOOLS_ to libvirt code is not good.
>>
>
> Can you tell us the error message you get ? I think the problem is
> probably that libvirt is trying to use libxc directly.
>
The libvirt libxl driver doesn't use libxc directly. AFAICT, the problem
is that libxl.h includes <xen/sysctl.h>, which has this
#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
#error "sysctl operations are intended for use by node control tools only"
#endif
Without the defines, Bamvor is hitting the #error directive.
Regards,
Jim
next prev parent reply other threads:[~2012-02-22 21:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 9:00 [xen-devel] [PATCH] libxl: fix compile error of libvirt Bamvor Jian Zhang
2012-02-21 18:02 ` Ian Jackson
2012-02-22 7:58 ` Bamvor Jian Zhang
2012-02-22 11:52 ` Ian Jackson
2012-02-22 12:10 ` Ian Campbell
2012-02-22 21:40 ` Jim Fehlig [this message]
2012-02-23 8:45 ` Ian Campbell
2012-02-23 8:52 ` Ian Campbell
2012-02-23 11:01 ` Ian Campbell
2012-02-24 12:18 ` Ian Jackson
2012-02-24 12:42 ` Ian Campbell
2012-02-24 15:42 ` Ian Jackson
2012-02-24 16:51 ` Ian Campbell
2012-02-23 2:42 ` Bamvor Jian Zhang
2012-02-22 21:42 ` Jim Fehlig
2012-02-23 8:59 ` Ian Campbell
2012-02-24 3:05 ` Jim Fehlig
2012-02-24 8:54 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2012-02-21 2:06 Bamvor Jian Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4560BC.30002@suse.com \
--to=jfehlig@suse.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=bjzhang@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).