From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [xen-devel] [PATCH] libxl: fix compile error of libvirt Date: Wed, 22 Feb 2012 14:40:12 -0700 Message-ID: <4F4560BC.30002@suse.com> References: <4F427C2B0200003000000BDD@novprvlin0050.provo.novell.com> <20291.56383.499378.463797@mariner.uk.xensource.com> <4F45109C02000030000011FC@novprvlin0050.provo.novell.com> <20292.55062.209546.961330@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20292.55062.209546.961330@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Bamvor Jian Zhang List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Bamvor Jian Zhang writes ("Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt"): > >> Ian Jackson wrote: >> >>> Users of libxl should not be using libxc directly and therefore should >>> not be including xenctrl.h. >>> > ... > >> but after your commit "23174:751c6dcec0d4"(remove xenctrl.h from libxl.h), the aplication(like libvirt) compile fail. How do i deal with it? >> it seems that add __XEN_TOOLS_ to libvirt code is not good. >> > > Can you tell us the error message you get ? I think the problem is > probably that libvirt is trying to use libxc directly. > The libvirt libxl driver doesn't use libxc directly. AFAICT, the problem is that libxl.h includes , which has this #if !defined(__XEN__) && !defined(__XEN_TOOLS__) #error "sysctl operations are intended for use by node control tools only" #endif Without the defines, Bamvor is hitting the #error directive. Regards, Jim