From mboxrd@z Thu Jan  1 00:00:00 1970
From: annie li <annie.li@oracle.com>
Subject: Re: [PATCH] hvm: Correct RTC time offset update error
 due to tm->tm_year
Date: Thu, 23 Feb 2012 23:17:01 +0800
Message-ID: <4F46586D.30605@oracle.com>
References: <4F41F41F.9060601@oracle.com>	<A9667DDFB95DB7438FA9D7D576C3D87E073EDE@SHSMSX101.ccr.corp.intel.com>	<CABaSDNjRaqEKCQuxTRRXpXQnEW4=4Yo_HW7hFObyRhbn8HD+Aw@mail.gmail.com>	<A9667DDFB95DB7438FA9D7D576C3D87E07565C@SHSMSX101.ccr.corp.intel.com>	<4F430201.3040208@oracle.com>	<1329908701.2880.26.camel@zakaz.uk.xensource.com>	<4F44E94A.2060209@oracle.com>
	<1329919132.8557.2.camel@zakaz.uk.xensource.com>
	<4F4652BB.4020809@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4F4652BB.4020809@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: annie li <annie.li@oracle.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Kurt Hackel <Kurt.Hackel@oracle.com>, young zhang <young.zhang.free@gmail.com>, "Zhang,
	Yang Z" <yang.z.zhang@intel.com>
List-Id: xen-devel@lists.xenproject.org



On 2012-2-23 22:52, annie li wrote:
>
>
> On 2012-2-22 21:58, Ian Campbell wrote:
>>
>> Yes, this looks plausible to me (although I'm no expert on this code).
>> Something similar happens in rtc_next_second.
>> Perhaps it would be better to add a function or macro to do the
>> conversion, such that it is somewhat self documenting? Or at least make
>> the 1900 a #define with a suitable name.
>>   
> I changed the 1900 to a macro and added a new function get_year. The 
> new patch is attached.
Sorry, two macro define: epoch_year and get_year.

Thanks
Annie

                {