From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 7/8] arm: use bootargs for the command line
Date: Wed, 14 Mar 2012 11:26:41 +0000 [thread overview]
Message-ID: <4F608071.7030200@citrix.com> (raw)
In-Reply-To: <1331721974.23971.392.camel@zakaz.uk.xensource.com>
On 14/03/12 10:46, Ian Campbell wrote:
> On Tue, 2012-02-28 at 16:54 +0000, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> Use the /chosen node's bootargs parameter for the Xen command line.
>> Parse it early on before the serial console is setup.
>>
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
>
> Looks good to me. Did you build/test the cmdline_parse change on x86 (or
> non-ARM) too?
I built it for x86, yes. I also looked quite carefully at
cmdline_parse() -- it seems the missing const is an accidental ommision.
> Assuming that changes stands alone it might be useful to split it out
> and submit it to Keir separately.
Ok.
David
next prev parent reply other threads:[~2012-03-14 11:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 16:54 [PATCH 0/8] arm: pass a device tree to dom0 David Vrabel
2012-02-28 16:54 ` [PATCH 1/8] arm: add generated files to .gitignore and .hgignore David Vrabel
2012-03-14 9:53 ` Ian Campbell
2012-02-28 16:54 ` [PATCH 2/8] device tree: correctly ignore unit-address when matching nodes by name David Vrabel
2012-03-14 10:00 ` Ian Campbell
2012-03-14 10:48 ` David Vrabel
2012-02-28 16:54 ` [PATCH 3/8] device tree: add device_tree_for_each_node() David Vrabel
2012-03-14 10:08 ` Ian Campbell
2012-03-14 11:01 ` David Vrabel
2012-03-14 11:09 ` Ian Campbell
2012-02-28 16:54 ` [PATCH 4/8] device tree: add device_tree_dump() to print a flat device tree David Vrabel
2012-03-14 10:11 ` Ian Campbell
2012-02-28 16:54 ` [PATCH 5/8] arm: remove the hack for loading vmlinux images David Vrabel
2012-03-14 10:17 ` Ian Campbell
2012-03-14 10:51 ` David Vrabel
2012-02-28 16:54 ` [PATCH 6/8] device tree, arm: supply a flat device tree to dom0 David Vrabel
2012-03-14 10:44 ` Ian Campbell
2012-03-14 11:17 ` David Vrabel
2012-03-14 13:00 ` Ian Campbell
2012-02-28 16:54 ` [PATCH 7/8] arm: use bootargs for the command line David Vrabel
2012-03-14 10:46 ` Ian Campbell
2012-03-14 11:26 ` David Vrabel [this message]
2012-02-28 16:54 ` [PATCH 8/8] arm: add dom0_mem command line argument David Vrabel
2012-03-14 10:48 ` Ian Campbell
2012-03-14 11:27 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F608071.7030200@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).