From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH v6 2/6] Introduce "save_devices" Date: Fri, 16 Mar 2012 09:36:21 -0600 Message-ID: <4F635DF5.8020207@redhat.com> References: <1331835548-537-2-git-send-email-stefano.stabellini@eu.citrix.com> <4F624E0F.6050909@codemonkey.ws> <20120315173456.0f297edf@doriath.home> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3B895BB17D193E34C0DAC8D1" Return-path: In-Reply-To: <20120315173456.0f297edf@doriath.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Luiz Capitulino Cc: xen-devel@lists.xensource.com, Stefano Stabellini , jan.kiszka@siemens.com, qemu-devel@nongnu.org, avi@redhat.com, Anthony Liguori List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3B895BB17D193E34C0DAC8D1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/15/2012 02:34 PM, Luiz Capitulino wrote: > On Thu, 15 Mar 2012 15:16:15 -0500 > Anthony Liguori wrote: >=20 >> On 03/15/2012 01:19 PM, Stefano Stabellini wrote: >>> - add an "is_ram" flag to SaveStateEntry; >>> >>> - register_savevm_live sets is_ram for live_savevm devices; >>> >>> - introduce a "save_devices" QAPI command that can be used to save >>> the state of all devices, but not the RAM or the block devices of the= >>> VM. >>> >>> +SQMP >>> +save_devices >>> +------- >>> + >>> +Save the state of all devices to file. The RAM and the block devices= >>> +of the VM are not saved by this command. >>> + >>> +Arguments: >>> + >>> +- "filename": the file to save the state of the devices to as binary= >>> +data. See save_devices.txt for a description of the binary format. >>> + >>> +Example: >>> + >>> +-> { "execute": "save_devices", "arguments": { "filename": "/tmp/sa= ve" } } Why are we adding yet another command without support for passing in an fd instead of having qemu open the file name? Libvirt really does want to move to an ability to pass in fds, and the more commands we add that open files, the harder converting them all will be. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig3B895BB17D193E34C0DAC8D1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPY131AAoJEKeha0olJ0NqiscH/i+5vIZcbCq+YovVnEOQIyVX a8vncYLbW8SJ63r9mOshTEU+bmKY1iF5CwLIZOR3x2DDubSWwZKXfM/zRi0WvAiC 6rQTy8gvtHJ7TknRL5OOal29SHw/EeIFvTW4fhPJ9WsSqmAfOcr8teqM4jZt7PS6 dv8iHvZgSLw+iJoOsBGyGhK/nZHwR7PbR5dMKltSbco8dbw+UA3gFuN5HfedBQk9 a3Qc7rEUMPzfIlm9Dw36XB/GhxLsI/9jc+F+VqwxGJmUeV5Z+Hg8E13gEte5KM+L K34QswIG++9nF8O12PBq+mj4akFr8C9aiVNrHlD/kUIhaLRfOZ+pdPd8DGknksY= =TPD5 -----END PGP SIGNATURE----- --------------enig3B895BB17D193E34C0DAC8D1--