From mboxrd@z Thu Jan  1 00:00:00 1970
From: Attilio Rao <attilio.rao@citrix.com>
Subject: Re: [PATCH] [PATCH v3] Fetch the OVMF repository from
 specific git mirror and enable it
Date: Sat, 17 Mar 2012 22:33:02 +0000
Message-ID: <4F65111E.8030507@citrix.com>
References: <402a1e16b2d8f24725cc.1330630107@dhcp-3-145.uk.xensource.com>
	<20320.35396.254724.585442@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20320.35396.254724.585442@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 14/03/12 12:08, Ian Jackson wrote:
> Attilio Rao writes ("[Xen-devel] [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it"):
>    
>> Signed-off-by: Attilio Rao<attilio.rao@citrix.com>
>>      
> cp ovmf-makefile ovmf/Makefile;
> Switched to a new branch 'dummy'
> cp seabios-config seabios-dir/.config;
> make subdirs-all
> make[4]: Entering directory `/u/iwj/work/xen-unstable-tools.hg/tools/firmware'
> make[5]: Entering directory `/u/iwj/work/xen-unstable-tools.hg/tools/firmware'
> make -C ovmf all
> make[6]: Entering directory `/u/iwj/work/xen-unstable-tools.hg/tools/firmware/ovmf-remote'
> make[6]: warning: -jN forced in submake: disabling jobserver mode.
> OvmfPkg/build.sh -a X64
> Initializing workspace
> /u/iwj/work/xen-unstable-tools.hg/tools/firmware/ovmf-remote/BaseTools
> Unable to find expected bin path under $EDK_TOOLS_PATH!
>    
>> /u/iwj/work/xen-unstable-tools.hg/tools/firmware/ovmf-remote/BaseTools/Bin/Linux-i486
>>      
> make[6]: *** [ovmf.bin] Error 1
> make[6]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools/firmware/ovmf-remote'
>    

I think I see the issue here. Are you running with i486 as an arch?
This is a deficiency of the OVMF support, because it has some wrappers 
to build appropriately the firmware which are OS and architectures 
specific and it does support Linux-i686 and Linux-x86_64 but not Linux-i486.
I'm not sure about what we should do here, possible options include:
- Verify that, on all i486,i586,etc. we can eventually use i686 and 
unify the script to do that
- Check if it is possible (it doesn't seem to be already present, but I 
will dig further) if we can "cross-compile" the compiling OS and family 
and use a mechanism to offer that

In any case we should check for the presence of the right wrapper and 
skip ovmf, spitting out an informative error, if this is really the case.

Do you have feedback on the matter?

Attilio