From mboxrd@z Thu Jan 1 00:00:00 1970 From: Attilio Rao Subject: Re: [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it Date: Mon, 19 Mar 2012 17:40:57 +0000 Message-ID: <4F676FA9.3090401@citrix.com> References: <402a1e16b2d8f24725cc.1330630107@dhcp-3-145.uk.xensource.com> <20320.35396.254724.585442@mariner.uk.xensource.com> <4F65111E.8030507@citrix.com> <20327.24718.845063.909876@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9213327932722079016==" Return-path: In-Reply-To: <20327.24718.845063.909876@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Ian Campbell , Christoph Egger , =?ISO-8859-1?Q?Roger_Pau_?= =?ISO-8859-1?Q?Monn=E9?= Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --===============9213327932722079016== Content-Type: multipart/alternative; boundary="------------010807050106060609050306" --------------010807050106060609050306 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 19/03/12 16:36, Ian Jackson wrote: > Attilio Rao writes ("Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it"): > >> I think I see the issue here. Are you running with i486 as an arch? >> This is a deficiency of the OVMF support, because it has some wrappers >> to build appropriately the firmware which are OS and architectures >> specific and it does support Linux-i686 and Linux-x86_64 but not Linux-i486. >> I'm not sure about what we should do here, possible options include: >> - Verify that, on all i486,i586,etc. we can eventually use i686 and >> unify the script to do that >> > Surely it's just wanting to know roughly what architecture to build > for. The difference between i686 and i486 isn't relevant here. > (I hope. If it is then we have other problems because this is tested > at build-time and might be run on a different kernel to the one it's > built on.) > > So I think this is the right thing to do. > > Here is my take on OVMF for what is needed: http://xenbits.xen.org/people/attilio/ovmf-xen-arches.patch This should at least fix tianocore to build on all i*86 Linux flavours. Unfortunately I don't have a NetBSD machine to test it out, so if Christoph and/or Roger can apply this patch to ovmf and try the original patch on this thread (and verify NetBSD can build ok) I'll propose this patch upstream for TIANOCORE, otherwise I will just send out a patch with OVMF disabled until NetBSD is not tested. Thanks, Attilio --------------010807050106060609050306 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 19/03/12 16:36, Ian Jackson wrote: 
Attilio Rao writes ("Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it"):
  
I think I see the issue here. Are you running with i486 as an arch?
This is a deficiency of the OVMF support, because it has some wrappers 
to build appropriately the firmware which are OS and architectures 
specific and it does support Linux-i686 and Linux-x86_64 but not Linux-i486.
I'm not sure about what we should do here, possible options include:
- Verify that, on all i486,i586,etc. we can eventually use i686 and 
unify the script to do that
    
Surely it's just wanting to know roughly what architecture to build
for.  The difference between i686 and i486 isn't relevant here.
(I hope.  If it is then we have other problems because this is tested
at build-time and might be run on a different kernel to the one it's
built on.)

So I think this is the right thing to do.

Here is my take on OVMF for what is needed:
http://xenbits.xen.org/people/attilio/ovmf-xen-arches.patch

This should at least fix tianocore to build on all i*86 Linux flavours.
Unfortunately I don't have a NetBSD machine to test it out, so if Christoph and/or Roger can apply this patch to ovmf and try the original patch on this thread (and verify NetBSD can build ok) I'll propose this patch upstream for TIANOCORE, otherwise I will just send out a patch with OVMF disabled until NetBSD is not tested.

Thanks,
Attilio
--------------010807050106060609050306-- --===============9213327932722079016== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9213327932722079016==--