xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 01/11] libfdt: move headers to xen/include/xen/libfdt/
Date: Mon, 19 Mar 2012 17:58:10 +0000	[thread overview]
Message-ID: <4F6773B2.70601@citrix.com> (raw)
In-Reply-To: <1332179529-1828-2-git-send-email-david.vrabel@citrix.com>

On 19/03/12 17:51, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
> 
> Move the public libfdt headers to xen/include/xen/libfdt/ so CFLAGS
> does need to be set to find them.  This requires minor tweaks to one
> of the headers imported from upstream.
> 
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>

Sorry, forgot the -M option when generating this.  The real diff is much
more modest.

8<--------------------
[PATCH] libfdt: move headers to xen/include/xen/libfdt/

Move the public libfdt headers to xen/include/xen/libfdt/ so CFLAGS
does need to be set to find them.  This requires minor tweaks to one
of the headers imported from upstream.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
 xen/common/Makefile                             |    2 --
 xen/common/device_tree.c                        |    3 +--
 xen/common/libfdt/Makefile                      |    2 +-
 xen/{common => include/xen}/libfdt/fdt.h        |    0
 xen/{common => include/xen}/libfdt/libfdt.h     |    4 ++--
 xen/{common => include/xen}/libfdt/libfdt_env.h |    0
 6 files changed, 4 insertions(+), 7 deletions(-)
 rename xen/{common => include/xen}/libfdt/fdt.h (100%)
 rename xen/{common => include/xen}/libfdt/libfdt.h (99%)
 rename xen/{common => include/xen}/libfdt/libfdt_env.h (100%)

diff --git a/xen/common/Makefile b/xen/common/Makefile
index 372b259..9f2e0d6 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -61,5 +61,3 @@ subdir-$(ia64) += hvm

 subdir-y += libelf
 subdir-$(HAS_DEVICE_TREE) += libfdt
-
-CFLAGS += -Ilibfdt
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index d50cb9c..140d342 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -14,13 +14,12 @@
 #include <xen/device_tree.h>
 #include <xen/kernel.h>
 #include <xen/lib.h>
+#include <xen/libfdt/libfdt.h>
 #include <xen/mm.h>
 #include <xen/stdarg.h>
 #include <xen/string.h>
 #include <asm/early_printk.h>

-#include <libfdt.h>
-
 struct dt_early_info __initdata early_info;
 void *device_tree_flattened;

diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile
index 0e65bc0..7578fe9 100644
--- a/xen/common/libfdt/Makefile
+++ b/xen/common/libfdt/Makefile
@@ -2,4 +2,4 @@ include Makefile.libfdt

 obj-y += $(LIBFDT_OBJS)

-CFLAGS += -I.
+CFLAGS += -I$(BASEDIR)/include/xen/libfdt/
diff --git a/xen/common/libfdt/fdt.h b/xen/include/xen/libfdt/fdt.h
similarity index 100%
rename from xen/common/libfdt/fdt.h
rename to xen/include/xen/libfdt/fdt.h
diff --git a/xen/common/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h
similarity index 99%
rename from xen/common/libfdt/libfdt.h
rename to xen/include/xen/libfdt/libfdt.h
index 55f3eb3..6086047 100644
--- a/xen/common/libfdt/libfdt.h
+++ b/xen/include/xen/libfdt/libfdt.h
@@ -51,8 +51,8 @@
  *     EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */

-#include <libfdt_env.h>
-#include <fdt.h>
+#include <xen/libfdt/libfdt_env.h>
+#include <xen/libfdt/fdt.h>

 #define FDT_FIRST_SUPPORTED_VERSION	0x10
 #define FDT_LAST_SUPPORTED_VERSION	0x11
diff --git a/xen/common/libfdt/libfdt_env.h
b/xen/include/xen/libfdt/libfdt_env.h
similarity index 100%
rename from xen/common/libfdt/libfdt_env.h
rename to xen/include/xen/libfdt/libfdt_env.h
-- 
1.7.2.5

  reply	other threads:[~2012-03-19 17:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 17:51 [PATCHv2 00/11] arm: pass a device tree to dom0 David Vrabel
2012-03-19 17:51 ` [PATCH 01/11] libfdt: move headers to xen/include/xen/libfdt/ David Vrabel
2012-03-19 17:58   ` David Vrabel [this message]
2012-03-19 17:52 ` [PATCH 02/11] MAINTAINERS: add device tree maintainer David Vrabel
2012-03-19 17:54   ` Keir Fraser
2012-03-19 17:52 ` [PATCH 03/11] device tree: follow coding style David Vrabel
2012-03-19 17:52 ` [PATCH 04/11] device tree: correctly ignore unit-address when matching nodes by name David Vrabel
2012-03-19 17:52 ` [PATCH 05/11] device tree: add device_tree_for_each_node() David Vrabel
2012-03-22 11:12   ` Ian Campbell
2012-03-22 12:47     ` David Vrabel
2012-03-19 17:52 ` [PATCH 06/11] device tree: add device_tree_dump() to print a flat device tree David Vrabel
2012-03-19 17:52 ` [PATCH 07/11] arm: remove the hack for loading vmlinux images David Vrabel
2012-03-19 17:52 ` [PATCH 08/11] device tree, arm: supply a flat device tree to dom0 David Vrabel
2012-03-20 10:43   ` David Vrabel
2012-03-20 10:52     ` Ian Campbell
2012-03-22 14:06   ` Ian Campbell
2012-03-22 14:27     ` David Vrabel
2012-03-22 17:12     ` David Vrabel
2012-03-19 17:52 ` [PATCH 09/11] Allow cmdline_parse() to be used with const strings David Vrabel
2012-03-19 17:54   ` Keir Fraser
2012-03-19 17:52 ` [PATCH 10/11] arm: use bootargs for the command line David Vrabel
2012-03-22 14:22   ` Ian Campbell
2012-03-22 14:30     ` Ian Campbell
2012-03-22 15:03     ` David Vrabel
2012-03-19 17:52 ` [PATCH 11/11] arm: add dom0_mem command line argument David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6773B2.70601@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).