From mboxrd@z Thu Jan 1 00:00:00 1970 From: Attilio Rao Subject: Re: [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it Date: Tue, 20 Mar 2012 12:12:20 +0000 Message-ID: <4F687424.80000@citrix.com> References: <402a1e16b2d8f24725cc.1330630107@dhcp-3-145.uk.xensource.com> <20320.35396.254724.585442@mariner.uk.xensource.com> <4F65111E.8030507@citrix.com> <20327.24718.845063.909876@mariner.uk.xensource.com> <4F676FA9.3090401@citrix.com> <4F6771F4.1060607@citrix.com> <4F6856B8.7080300@amd.com> <4F686579.3050900@citrix.com> <4F68709E.7060304@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F68709E.7060304@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Christoph Egger Cc: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= , "xen-devel@lists.xensource.com" , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 20/03/12 11:57, Christoph Egger wrote: > On 03/20/12 12:09, Attilio Rao wrote: > >> On 20/03/12 10:06, Christoph Egger wrote: >> >>> On 03/19/12 18:50, Attilio Rao wrote: >>> >>>> On 19/03/12 17:40, Attilio Rao wrote: >>>> >>>>> On 19/03/12 16:36, Ian Jackson wrote: >>>>> >>>>>> Attilio Rao writes ("Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the >>>>>> OVMF repository from specific git mirror and enable it"): >>>>>> >>>>>>> I think I see the issue here. Are you running with i486 as an arch? >>>>>>> This is a deficiency of the OVMF support, because it has some >>>>>>> wrappers >>>>>>> to build appropriately the firmware which are OS and architectures >>>>>>> specific and it does support Linux-i686 and Linux-x86_64 but not >>>>>>> Linux-i486. >>>>>>> I'm not sure about what we should do here, possible options include: >>>>>>> - Verify that, on all i486,i586,etc. we can eventually use i686 and >>>>>>> unify the script to do that >>>>>>> >>>>>> Surely it's just wanting to know roughly what architecture to build >>>>>> for. The difference between i686 and i486 isn't relevant here. >>>>>> (I hope. If it is then we have other problems because this is tested >>>>>> at build-time and might be run on a different kernel to the one it's >>>>>> built on.) >>>>>> >>>>>> So I think this is the right thing to do. >>>>>> >>>>>> >>>>> Here is my take on OVMF for what is needed: >>>>> http://xenbits.xen.org/people/attilio/ovmf-xen-arches.patch >>>>> >>>>> >>>>> This should at least fix tianocore to build on all i*86 Linux flavours. >>>>> Unfortunately I don't have a NetBSD machine to test it out, so if >>>>> Christoph and/or Roger can apply this patch to ovmf and try the >>>>> original patch on this thread (and verify NetBSD can build ok) I'll >>>>> propose this patch upstream for TIANOCORE, otherwise I will just send >>>>> out a patch with OVMF disabled until NetBSD is not tested. >>>>> >>>>> >>>> To be more precise, you don't even need the patch at the beginning of >>>> the thread, all you need to do to test you can build OVMF on NetBSD is: >>>> - git clone git://xenbits.xen.org/ovmf.git >>>> - apply the patch above >>>> - cd ovmf/OvmfPkg/ >>>> - $ ./build.sh >>>> - $ ./build.sh -a X64 >>>> >>> The build fails that build.sh is a bash-script and not a /bin/sh script. >>> >>> >> Please forget my previous e-mail. >> I've updated the patch (same link) and I'd be grateful if you can give >> it a try now. >> > I replaced #!/bin/bash with #!/usr/bin/env bash in the entire tree and > get this: > > Initializing workspace > /data/xen-ovmf/ovmf/BaseTools > WORKSPACE: /data/xen-ovmf/ovmf > EDK_TOOLS_PATH: /data/xen-ovmf/ovmf/BaseTools > Copying $EDK_TOOLS_PATH/Conf/build_rule.template > to $WORKSPACE/Conf/build_rule.txt > Copying $EDK_TOOLS_PATH/Conf/FrameworkDatabase.template > to $WORKSPACE/Conf/FrameworkDatabase.txt > Copying $EDK_TOOLS_PATH/Conf/tools_def.template > to $WORKSPACE/Conf/tools_def.txt > Copying $EDK_TOOLS_PATH/Conf/target.template > to $WORKSPACE/Conf/target.txt > Building tools as they are not in the path > SourceCMakefilesNmakeSubdirs.bat: not found > > > Yes, you also need to replace make with gmake in installation scripts. >> (Sorry but I really don't have now a NetBSD machine to test on, so I >> cannot really catch even silly mistakes). >> > Installing NetBSD in a virtual machine is not an option? > > I'm trying that with a native FreeBSD, will let you know once I have a patch ready to go. Attilio