From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH] libxl: Query VNC listening port through QMP Date: Wed, 18 Apr 2012 12:14:49 +0100 Message-ID: <4F8EA229.9000308@citrix.com> References: <1334600151-22282-1-git-send-email-anthony.perard@citrix.com> <1334676652.23948.112.camel@zakaz.uk.xensource.com> <4F8D902A.2080607@citrix.com> <1334747100.23948.202.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1334747100.23948.202.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , Xen Devel List-Id: xen-devel@lists.xenproject.org On 18/04/12 12:05, Ian Campbell wrote: > On Tue, 2012-04-17 at 16:45 +0100, Anthony PERARD wrote: >> On 17/04/12 16:30, Ian Campbell wrote: >>> On Mon, 2012-04-16 at 19:15 +0100, Anthony PERARD wrote: >>>> Currently `xl vncviewer $dom` does not work because the VNC port is not >>>> registered in xenstore when using qemu-upstream. This patch attempted to fix >>>> this. >>> >>> libxl_vncviewer_exec also potentially reads vnc-pass, although frankly >>> having such a thing in xenstore strikes me as something of a >>> misfeature... >> >> Well, I thought of that, but when I tried `xl vncviewer` with a password >> set, the result was that vncviewer asked me a password. That why I >> haven't put more effort in querrying the vnc password from QEMU. > > Same here even with qemu-xen-traditional. There is actually an option to xl vncviewer: --autopass, so with this, no need to enter the vnc pass manually. And it's works fine with the traditionnal. > I'm tempted to suggest that we remove this support -- having plain text > passwords in xenstore (thankfully with perms set somewhat sanely) just > doesn't seem like a Good Thing to me... -- Anthony PERARD