From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v3 2/5] libxl: add libxl__xs_path_cleanup Date: Mon, 23 Apr 2012 16:42:42 +0100 Message-ID: <4F957872.3080502@citrix.com> References: <1334928211-29856-1-git-send-email-roger.pau@citrix.com> <1334928211-29856-3-git-send-email-roger.pau@citrix.com> <20373.30292.162693.913028@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20373.30292.162693.913028@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Jackson escribi=F3: > Roger Pau Monne writes ("[Xen-devel] [PATCH v3 2/5] libxl: add libxl__xs_= path_cleanup"): >> Add a function which behaves like "xenstore-rm -t", and which will be us= ed to >> clean xenstore after unplug since we will be no longer executing >> xen-hotplug-cleanup script, that used to do that for us. > > This is all rather odd. I hadn't previously noticed the existence of > xenstore-rm -t. > > With the C xenstored, the RM command will delete a whole directory > tree, regardless of its contents. This is documented in > docs/misc/xenstore.txt. This is a recursive delete, from top to bottom, let me put an example = which will make this clear, since probably the title is wrong. Imagine = you have the following xenstore entry: /foo/bar/baz =3D 123 If you do a: xenstore-rm /foo/bar/baz the following will remain in xenstore: /foo/bar What this function does is clean empty folders that contained the = deleted entry, so using this function on /foo/bar/baz would have cleaned = the whole directory. > The comment in xs.c near xs_rm, which says that directories must be > empty, seems to be wrong. > > What does oxenstored do ? I'm tempted to say that it should follow > the C xenstored behaviour. > > Ian.