From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] fix build error with seabios Date: Wed, 25 Apr 2012 11:52:46 +0200 Message-ID: <4F97C96E.8030401@amd.com> References: <4F8836C9.9080502@amd.com> <20374.57450.417199.89376@mariner.uk.xensource.com> <1335341262.4881.15.camel@dagon.hellion.org.uk> <4F97B941.7000108@amd.com> <1335343957.28015.1.camel@zakaz.uk.xensource.com> <4F97BF95.6050209@amd.com> <4F97C041.50205@amd.com> <1335345652.28015.12.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1335345652.28015.12.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/25/12 11:20, Ian Campbell wrote: > On Wed, 2012-04-25 at 10:13 +0100, Christoph Egger wrote: >> On 04/25/12 11:10, Christoph Egger wrote: >> >>> On 04/25/12 10:52, Ian Campbell wrote: >>> >>>> On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote: >>>>> On 04/25/12 10:07, Ian Campbell wrote: >>>>> >>>>>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote: >>>>>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"): >>>>>>>> >>>>>>>> Pass PYTHON down to seabios, so seabios will >>>>>>>> use same python binary as whole xen tree does. >>>>>>>> Fixes build error on NetBSD. >>>>>>> >>>>>>> Ian, does this look sensible to you ? >>>>>> >>>>>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that >>>>>> is OK, so we might as well take this now. >>>>> >>>>> >>>>> Thanks. >>> >>>>> >>> >>>>>> Does >>>>>> subdirs-seabios: PYTHON=$(PYTHON) >>>>>> (or something similar) work? Might be a better option in the future >>>>> >>>>> No, this doesn't work. >>>> >>>> What about >>>> subdir-all-seabios: PYTHON=... >>>> ? >>> >>> >>> No, doesn't work. I also tried without success: >>> >>> subdirs-all-seabios >>> subdir-all-seabios-dir >>> subdirs-all-seabios-dir >>> seabios-dir >> >> I found something that works: >> >> subdir-all-seabios-dir: >> export PYTHON=$(PYTHON) > > Really, that's not a syntax I've ever seen before, I've no idea how that > works, all on the same line, sure, but on the next line like that, odd!. > I would have thought that this would have caused "export PYTHON= > $(PYTHON)" to be run it its own new subshell which would immediately > exit. > > Anyway, I guess if it works we might as well use this version... No, it doesn't. It causes a subsequent seabios build error about a missing build rule. I should have waited with reporting this till the build finished. Christoph > > > Ian. > >> >> Christoph >>> >>>>>>> >>>>>>>> Signed-off-by: Christoph Egger >>>>>> >>>>>> Acked-by: Ian Campbell >>>>>> >>>>>>>> >>>>>>>> ---------------------------------------------------------------------- >>>>>>>> diff -r ab552da976a3 tools/firmware/Makefile >>>>>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200 >>>>>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200 >>>>>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) >>>>>>>> false ; \ >>>>>>>> fi >>>>>>>> endif >>>>>>>> - $(MAKE) subdirs-$@ >>>>>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ >>>>>>>> >>>>>>>> >>>>>>>> .PHONY: install >>>>>>>> >>>>>>>> ---------------------------------------------------------------------- >>> >>> >> >> >> > > > -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632