xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] libxl: prevent xl from running if xend is running.
Date: Wed, 25 Apr 2012 11:32:00 +0100	[thread overview]
Message-ID: <4F97D2A0.2060207@citrix.com> (raw)
In-Reply-To: <20375.53553.269226.466311@mariner.uk.xensource.com>

Ian Jackson escribió:
> Roger Pau Monne writes ("Re: [PATCH v2] libxl: prevent xl from running if xend is running."):
>> Ian Jackson escribió:
> ...
>>> Thanks, but I'm afraid this needs a refresh.  I recommend you wait
>>> until tomorrow.  I'm nearly at the end of my huge queue...
>> Do you mean that the code doesn't apply cleanly, or a refresh in the
>> commit message?
>
> The former.

Anyway I'm going to make the change requested by Ian Campbell, and I'm 
going to add an enum to define the type of commands, currently I have 
the following names:

STATIC: doesn't modify anything
DRY_RUN: modifies, but has a dry_run option
MODIFIES: modifies, but has no dry_run option

The names are crap, so if you have a better naming scheme I'm open to 
suggestions.

>
>> In the lists of changes I've added the fact that now you are able to run
>> commands that doesn't modify anything.
>
> Right, yes, that's good.
>
> Thanks,
> Ian.

  reply	other threads:[~2012-04-25 10:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 18:05 [PATCH v2] libxl: prevent xl from running if xend is running Roger Pau Monne
2012-04-24 18:08 ` Ian Jackson
2012-04-25  8:36   ` Roger Pau Monne
2012-04-25 10:25     ` Ian Jackson
2012-04-25 10:32       ` Roger Pau Monne [this message]
2012-04-25 10:34         ` Ian Jackson
2012-04-25  9:22 ` Ian Campbell
2012-04-25 10:29   ` Ian Jackson
2012-04-25 11:04     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F97D2A0.2060207@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).