From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2] libxl/build: print a warning if
	flex/bison are needed
Date: Wed, 25 Apr 2012 11:46:48 +0100
Message-ID: <4F97D618.5010807@citrix.com>
References: <1335345282-42997-1-git-send-email-roger.pau@citrix.com>
	<20375.54724.573559.470745@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20375.54724.573559.470745@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Ian Jackson escribi=F3:
> Roger Pau Monne writes ("[PATCH v2] libxl/build: print a warning if flex/=
bison are needed"):
>> This patch adds better support for both Flex and Bison, which might
>> be needed to compile libxl. Now configure script sets BISON and FLEX
>> Makefile vars if bison and flex are found, but doesn't complain if
>> they are not found.
>>
>> Also, added some Makefile soccery to print a warning message if
>> Bison or Flex are needed but not found.
>
> Marvellous.  I have applied this.  I altered the warning message
> slightly:
>
>   +ifeq ($(FLEX),)
>   +%.c %.h:: %.l
> -+      $(warning Flex is needed to compile libxl, please install it and =
rerun \
> -+      configure)
> ++      $(warning Flex is needed to rebuild some libxl parsers and \
> ++                scanners, please install it and rerun configure)
>   +endif
>   +
>   +ifeq ($(BISON),)
>   +%.c %.h:: %.y
> -+      $(warning Bison is needed to compile libxl, please install it an =
rerun \
> -+      configure)
> ++      $(warning Bison is needed to rebuild some libxl parsers and \
> ++                scanners, please install it an rerun configure)
>   +endif
>   +
>
> I trust that's OK.

Sure, thanks!

> Thanks,
> Ian.