From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC V6 1/5] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks Date: Sun, 29 Apr 2012 16:26:21 +0300 Message-ID: <4F9D417D.1050105@redhat.com> References: <20120423095937.30893.14776.sendpatchset@codeblue.in.ibm.com> <20120423095947.30893.84029.sendpatchset@codeblue.in.ibm.com> <20120424095923.GS15413@redhat.com> <4F9D3F8B.9010805@redhat.com> <20120429132030.GB15413@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120429132030.GB15413@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Gleb Natapov Cc: X86 , Jeremy Fitzhardinge , Greg Kroah-Hartman , KVM , Konrad Rzeszutek Wilk , linux-doc@vger.kernel.org, LKML , Raghavendra K T , Virtualization , Ingo Molnar , Srivatsa Vaddagiri , Sasha Levin , "H. Peter Anvin" , Xen , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 04/29/2012 04:20 PM, Gleb Natapov wrote: > > > This is too similar to kvm_irq_delivery_to_apic(). Why not reuse it. We > > > can use one of reserved delivery modes as PV delivery mode. We will > > > disallow guest to trigger it through apic interface, so this will not be > > > part of ABI and can be changed at will. > > > > > > > I'm not thrilled about this. Those delivery modes will eventually > > become unreserved. We can have a kvm_lookup_apic_id() that is shared > > among implementations. > > > This is only internal implementation. If they become unreserved we will > use something else. > Yeah, I'm thinking of that time. Why do something temporary and fragile? -- error compiling committee.c: too many arguments to function