From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghavendra K T Subject: Re: [PATCH RFC V6 1/5] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks Date: Wed, 02 May 2012 01:50:06 +0530 Message-ID: <4FA04576.6030405@linux.vnet.ibm.com> References: <20120423095937.30893.14776.sendpatchset@codeblue.in.ibm.com> <20120423095947.30893.84029.sendpatchset@codeblue.in.ibm.com> <4F9D415B.7010103@redhat.com> <4F9E42F6.8050108@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F9E42F6.8050108@linux.vnet.ibm.com> Sender: linux-doc-owner@vger.kernel.org To: Avi Kivity Cc: Jeremy Fitzhardinge , Greg Kroah-Hartman , Alexander Graf , Randy Dunlap , linux-doc@vger.kernel.org, "H. Peter Anvin" , Konrad Rzeszutek Wilk , KVM , Stefano Stabellini , Virtualization , X86 , Gleb Natapov , Ingo Molnar , Marcelo Tosatti , LKML , Xen , Sasha Levin , Srivatsa Vaddagiri List-Id: xen-devel@lists.xenproject.org On 04/30/2012 01:14 PM, Raghavendra K T wrote: >>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >>> index 4044ce0..7fc9be6 100644 >>> --- a/arch/x86/kvm/x86.c >>> +++ b/arch/x86/kvm/x86.c >>> @@ -2147,6 +2147,7 @@ int kvm_dev_ioctl_check_extension(long ext) >>> case KVM_CAP_ASYNC_PF: >>> case KVM_CAP_GET_TSC_KHZ: >>> case KVM_CAP_PCI_2_3: >>> + case KVM_CAP_PV_UNHALT: >>> r = 1; >>> break; >>> case KVM_CAP_COALESCED_MMIO: >> >> Redundant, since we can infer this from KVM_GET_SUPPORTED_CPUID. But >> please indicate this in the documentation. >> > > Ok. will mention that in documentation added for KVM_CAP_PV_UNHALT. > I think it is better to remove KVM_CAP_PV_UNHALT itself and avoid spamming CAP.. will do that in coming version.