From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 5/8] xen/setup: Only print "Freeing XXX-YYY pfn range: Z pages freed" if Z > 0 Date: Thu, 3 May 2012 12:59:24 +0100 Message-ID: <4FA2731C.2050204@citrix.com> References: <1334596539-18172-1-git-send-email-konrad.wilk@oracle.com> <1334596539-18172-6-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1334596539-18172-6-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "JBeulich@suse.com" List-Id: xen-devel@lists.xenproject.org On 16/04/12 18:15, Konrad Rzeszutek Wilk wrote: > Otherwise we can get these meaningless: > Freeing bad80-badf4 pfn range: 0 pages freed > > We also can do this for the summary ones - no point of printing > "Set 0 page(s) to 1-1 mapping" > > [v1: Extended to the summary printks] > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: David Vrabel David > --- > arch/x86/xen/setup.c | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c > index 1ba8dff..7b0ab77 100644 > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > @@ -114,8 +114,9 @@ static unsigned long __init xen_release_chunk(unsigned long start, > len++; > } > } > - printk(KERN_INFO "Freeing %lx-%lx pfn range: %lu pages freed\n", > - start, end, len); > + if (len) > + printk(KERN_INFO "Freeing %lx-%lx pfn range: %lu pages freed\n", > + start, end, len); > > return len; > } > @@ -162,8 +163,10 @@ static unsigned long __init xen_set_identity_and_release( > } > } > > - printk(KERN_INFO "Released %lu pages of unused memory\n", released); > - printk(KERN_INFO "Set %ld page(s) to 1-1 mapping\n", identity); > + if (released) > + printk(KERN_INFO "Released %lu pages of unused memory\n", released); > + if (identity) > + printk(KERN_INFO "Set %ld page(s) to 1-1 mapping\n", identity); > > return released; > }