From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [xen-unstable test] 11946: regressions - FAIL Date: Mon, 7 May 2012 16:51:31 +0100 Message-ID: <4FA7EF83.3030902@citrix.com> References: <1329216291.31256.207.camel@zakaz.uk.xensource.com> <1332844592.25560.9.camel@zakaz.uk.xensource.com> <4FA437E7.6040105@citrix.com> <4FA79F9F0200007800081F5F@nat28.tlf.novell.com> <4FA7B6EF.9030403@citrix.com> <4FA7EB80020000780008204B@nat28.tlf.novell.com> <4FA7DF2B.3020000@citrix.com> <4FA7FE2C02000078000820A6@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FA7FE2C02000078000820A6@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "xen-devel@lists.xensource.com" , "Keir (Xen.org)" , Ian Campbell , Ian Jackson , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org On 07/05/2012 15:54, Jan Beulich wrote: >>>> On 07.05.12 at 16:41, Andrew Cooper wrote: >> It appears we have two functions to dump the IO-APIC state: >> __print_IO_APIC() which gets called on boot and from 'z', and >> dump_ioapic_irq_info() which gets called from the end of 'i'. These >> should probably be consolidated somehow. > Rather not - 'z' provides information on the IO-APIC that isn't > directly related to specific interrupts, while 'i' (when it comes to > the IO-APIC) is exclusively interested in the RTEs. Unless > dump_ioapic_irq_info() is _fully_ redundant with 'z' (didn't check > in detail yet), in which case I'd vote for removing this function. > > Jan > dump_ioapic_irq_info() loops through nr_irqs_gsi and uses irq_2_pin to work out which io-apic RTE to read and decode. __print_IO_APIC() loop through nr_ioapics, then through each RTE and decodes it. At the end, it loops through nr_irqs_gsi and matches irqs to ioapic:pin pairs. So they are probably different enough to be worth keeping. ~Andrew