From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Jan Beulich <JBeulich@suse.com>, Keir Fraser <keir@xen.org>
Subject: x86_64: fix naming of rflags in elf regset structure
Date: Tue, 8 May 2012 10:51:17 +0100 [thread overview]
Message-ID: <4FA8EC95.8020508@citrix.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
This is a trivial, non-functional, change so should be considered for
4.2, and backported to 4.1 and 4.0 release candidates.
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
[-- Attachment #2: x86-elf-rflags-name.patch --]
[-- Type: text/x-patch, Size: 1158 bytes --]
# HG changeset patch
# Parent 8f1e0cc4a507a52a49a2eb7832a57ecc7e032dce
x86_64: fix naming of rflags in elf regset structure
'pushfq' pushes rflags, not eflags. Fix up naming of the structure.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff -r 8f1e0cc4a507 xen/include/asm-x86/x86_64/elf.h
--- a/xen/include/asm-x86/x86_64/elf.h
+++ b/xen/include/asm-x86/x86_64/elf.h
@@ -20,7 +20,7 @@ typedef struct {
unsigned long orig_rax;
unsigned long rip;
unsigned long cs;
- unsigned long eflags;
+ unsigned long rflags;
unsigned long rsp;
unsigned long ss;
unsigned long thread_fs;
@@ -54,7 +54,7 @@ static inline void elf_core_save_regs(EL
/* orig_rax not filled in for now */
core_regs->rip = (unsigned long)elf_core_save_regs;
asm volatile("movl %%cs, %%eax;" :"=a"(core_regs->cs));
- asm volatile("pushfq; popq %0" :"=m"(core_regs->eflags));
+ asm volatile("pushfq; popq %0" :"=m"(core_regs->rflags));
asm volatile("movq %%rsp,%0" : "=m"(core_regs->rsp));
asm volatile("movl %%ss, %%eax;" :"=a"(core_regs->ss));
/* thread_fs not filled in for now */
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2012-05-08 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 9:51 Andrew Cooper [this message]
2012-05-08 13:09 ` x86_64: fix naming of rflags in elf regset structure Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA8EC95.8020508@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).