x86_64: fix naming of rflags in elf regset structure

x86_64: fix naming of rflags in elf regset structure

[Andrew Cooper]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

This is a trivial, non-functional, change so should be considered for
4.2, and backported to 4.1 and 4.0 release candidates.

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com


[-- Attachment #2: x86-elf-rflags-name.patch --]
[-- Type: text/x-patch, Size: 1158 bytes --]

# HG changeset patch
# Parent 8f1e0cc4a507a52a49a2eb7832a57ecc7e032dce
x86_64: fix naming of rflags in elf regset structure

'pushfq' pushes rflags, not eflags.  Fix up naming of the structure.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff -r 8f1e0cc4a507 xen/include/asm-x86/x86_64/elf.h
--- a/xen/include/asm-x86/x86_64/elf.h
+++ b/xen/include/asm-x86/x86_64/elf.h
@@ -20,7 +20,7 @@ typedef struct {
     unsigned long orig_rax;
     unsigned long rip;
     unsigned long cs;
-    unsigned long eflags;
+    unsigned long rflags;
     unsigned long rsp;
     unsigned long ss;
     unsigned long thread_fs;
@@ -54,7 +54,7 @@ static inline void elf_core_save_regs(EL
     /* orig_rax not filled in for now */
     core_regs->rip = (unsigned long)elf_core_save_regs;
     asm volatile("movl %%cs, %%eax;" :"=a"(core_regs->cs));
-    asm volatile("pushfq; popq %0" :"=m"(core_regs->eflags));
+    asm volatile("pushfq; popq %0" :"=m"(core_regs->rflags));
     asm volatile("movq %%rsp,%0" : "=m"(core_regs->rsp));
     asm volatile("movl %%ss, %%eax;" :"=a"(core_regs->ss));
     /* thread_fs not filled in for now */

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: x86_64: fix naming of rflags in elf regset structure

[Keir Fraser]

On 08/05/2012 10:51, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:

> This is a trivial, non-functional, change so should be considered for
> 4.2, and backported to 4.1 and 4.0 release candidates.

Since this doesn't fix anything, apart from a source-code name, this would
be pointless to backport.

 -- Keir