From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxl: Fix incorrect return of OSEVENT_HOOK macro
Date: Wed, 09 May 2012 09:50:31 -0400 [thread overview]
Message-ID: <4FAA7627.4010003@tycho.nsa.gov> (raw)
In-Reply-To: <20394.28433.983986.883494@mariner.uk.xensource.com>
On 05/09/2012 09:20 AM, Ian Jackson wrote:
> Daniel De Graaf writes ("[PATCH] libxl: Fix incorrect return of OSEVENT_HOOK macro"):
>> The OSEVENT_HOOK_INTERN macro incorrectly returned the value of the
>> expression CTX->osevent_in_hook-- (usually 1) instead of the value of
>> the function call it made. Change the macro to a statement including the
>> return variable to fix this.
>
> Also, does this mean that you're using this in anger, or did you just
> happen to spot it while perusing the code ?
>
> Thanks,
> Ian.
>
I am using this functionality in a locally-patched libvirt where I have
replaced libxl 4.1 support with 4.2. I don't think the changes I made are
suitable for upstream as I assume libvirt will want to continue to support
libxl 4.1 in addition to 4.2 (and my patch discards the 4.1 support).
--
Daniel De Graaf
National Security Agency
next prev parent reply other threads:[~2012-05-09 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 19:15 [PATCH] libxl: Fix incorrect return of OSEVENT_HOOK macro Daniel De Graaf
2012-05-09 13:19 ` Ian Jackson
2012-05-09 13:38 ` [PATCH v2] " Daniel De Graaf
2012-05-09 15:32 ` Ian Jackson
2012-05-09 16:42 ` Daniel De Graaf
2012-05-10 11:20 ` Ian Jackson
2012-05-09 13:20 ` [PATCH] " Ian Jackson
2012-05-09 13:50 ` Daniel De Graaf [this message]
2012-05-09 15:33 ` Ian Jackson
2012-05-09 17:13 ` [PATCH-RFC] Change libxl to use Xen 4.2 interface Daniel De Graaf
[not found] ` <1336583603-7029-1-git-send-email-dgdegra@tycho.nsa.gov>
2012-05-10 9:56 ` Ian Campbell
[not found] ` <1336643766.7098.40.camel@zakaz.uk.xensource.com>
2012-05-10 10:10 ` [libvirt] " Daniel P. Berrange
[not found] ` <20120510101043.GH1223@redhat.com>
2012-05-10 22:41 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAA7627.4010003@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).