From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH] libxl: Fix incorrect return of OSEVENT_HOOK macro Date: Wed, 09 May 2012 09:50:31 -0400 Message-ID: <4FAA7627.4010003@tycho.nsa.gov> References: <1336418109-6335-1-git-send-email-dgdegra@tycho.nsa.gov> <20394.28433.983986.883494@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20394.28433.983986.883494@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 05/09/2012 09:20 AM, Ian Jackson wrote: > Daniel De Graaf writes ("[PATCH] libxl: Fix incorrect return of OSEVENT_HOOK macro"): >> The OSEVENT_HOOK_INTERN macro incorrectly returned the value of the >> expression CTX->osevent_in_hook-- (usually 1) instead of the value of >> the function call it made. Change the macro to a statement including the >> return variable to fix this. > > Also, does this mean that you're using this in anger, or did you just > happen to spot it while perusing the code ? > > Thanks, > Ian. > I am using this functionality in a locally-patched libvirt where I have replaced libxl 4.1 support with 4.2. I don't think the changes I made are suitable for upstream as I assume libvirt will want to continue to support libxl 4.1 in addition to 4.2 (and my patch discards the 4.1 support). -- Daniel De Graaf National Security Agency