From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 2 of 4] libxl: Rename pci_list_assignable to pci_assignable_list Date: Thu, 10 May 2012 11:54:56 +0100 Message-ID: <4FAB9E80.9040308@eu.citrix.com> References: <5b5070d487d948ff654c.1336559322@kodo2> <1336646620.7098.66.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1336646620.7098.66.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 10/05/12 11:43, Ian Campbell wrote: > Acked-by: Ian Campbell > > (moving the definition of pcilist_assignable et al seems superfluous, > but I suppose it serves some purpose later in the series and the > function is small enough to review the changes + code motion by eye) Ah, right -- I didn't think about that. I'll try to avoid motion + changes in the future. You're right, the code motion is because we're changing the function from being mainly a "pcilist" thing (thus grouped with the other pci-list command) to mainly being an "assignable" thing (and thus grouped with other "assignable" commands). -George