Re: [PATCH 4 of 4] xl: Add pci_assignable_add and remove commands

[George Dunlap <george.dunlap@eu.citrix.com>]

On 11/05/12 12:19, Ian Campbell wrote:
> On Fri, 2012-05-11 at 12:13 +0100, George Dunlap wrote:
>>>> +
>>>> +static void pciassignable_remove(const char *bdf, int rebind)
>>>> +{
>>>> +    libxl_device_pci pcidev;
>>>> +    XLU_Config *config;
>>>> +
>>>> +    memset(&pcidev, 0x00, sizeof(pcidev));
>>> libxl_device_pci_init also.
>>>
>>> You are also missing the xlu_cfg_destroy both here and in the add fn.
>>>
>>> (it's a bit annoying that an XLU_COnfig is needed for these simple
>>> helper functions, I suppose it's for logging, but maybe they could log
>>> to stderr if cfg==NULL. Anyway, lets not fix that here)
>> Hmm -- I just copied and pasted from pciattach() and friends.  I'll fix
>> those up while I'm at it.
> Thanks, looked like my grep missed them somehow when I added the init
> fns. The reset of the memset's in xl_cmdimpl.c look ok except for:
>
>      memset(cpumap.map, 0, cpumap.size);
>
> in main_cpupoolnumasplit which smells a bit fishy -- I'll investigate
> that one...
OK -- I found another place xl_cfg_destroy() wasn't being called.  I 
think I'll send those as a separate clean-up series; but the new 
functions added in the series will have the fixes you suggested.

  -George