From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v6 04/11] libxl: move libxl__device_from_disk to libxl_internal.c Date: Fri, 18 May 2012 16:16:52 +0100 Message-ID: <4FB667E4.6010301@citrix.com> References: <1337350125-30394-4-git-send-email-stefano.stabellini@eu.citrix.com> <4FB662F5.2010704@citrix.com> <1337353377.22316.127.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1337353377.22316.127.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > On Fri, 2012-05-18 at 15:55 +0100, Roger Pau Monne wrote: >>> @@ -429,6 +429,46 @@ libxl_device_model_version >> libxl__device_model_version_running(libxl__gc *gc, >>> return value; >>> } >>> >>> +int libxl__device_from_disk(libxl__gc *gc, uint32_t domid, >>> + libxl_device_disk *disk, >>> + libxl__device *device) >> I think this should be moved to libxl_device instead of >> libxl_internal, since it's a device related function. > > I think it'd be better to leave it in the original file, libxl is so > confused about what goes where that it doesn't really matter... > > If we do want to move it we can do it later as a pure code motion > change. In my hotplug series I'm moving most libxl_device_{...}_add to provide an internal implementation that takes an ao, making something quite similar to what Stefano does, if I start moving all those to libxl_internal we will fill this file with functions that could be somewhere else (libxl_device). I understand that the libxl policy is put functions where they seem to belong (device related functions to libxl_device, domain related ones to libxl_dom...), and if they fit in none of this categories then put them in libxl_internal or create a new file. We can leave it in libxl_internal for now, and I will move it on my series. > Ian. > >