From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 11/13] libxl: set nic type to VIF by default
Date: Mon, 21 May 2012 17:29:06 +0100
Message-ID: <4FBA6D52.9050809@citrix.com>
References: <1337184716-49276-1-git-send-email-roger.pau@citrix.com>
	<1337184716-49276-12-git-send-email-roger.pau@citrix.com>
	<20406.31676.266501.253510@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20406.31676.266501.253510@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH 11/13] libxl: set nic type to VIF by default"):
>> Set the default value for nic interfaces to VIF, since it used to be
>> IOEMU, even for PV guests.
>
> How odd.
>
>> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
>> index 2490138..631de15 100644
>> --- a/tools/libxl/libxl.c
>> +++ b/tools/libxl/libxl.c
>> @@ -1637,7 +1637,7 @@ int libxl__device_nic_setdefault(libxl__gc *gc, libxl_device_nic *nic)
>>                                     libxl__xen_script_dir_path())<  0 )
>>           return ERROR_FAIL;
>>       if (!nic->nictype)
>> -        nic->nictype = LIBXL_NIC_TYPE_IOEMU;
>> +        nic->nictype = LIBXL_NIC_TYPE_VIF;
>
> But doesn't this set the default type to VIF even for HVM guests ?

Shouldn't HVM guests use the "ioemu" parameter if they want an emulated 
card? If no parameter is provided then the default type should be VIF, 
because there's no other way to specifically set the type to VIF.